1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
|
<?php
/**
* @covers VersionChecker
*/
class VersionCheckerTest extends PHPUnit\Framework\TestCase {
use MediaWikiCoversValidator;
use PHPUnit4And6Compat;
/**
* @dataProvider provideCheck
*/
public function testCheck( $coreVersion, $constraint, $expected ) {
$checker = new VersionChecker( $coreVersion );
$this->assertEquals( $expected, !(bool)$checker->checkArray( [
'FakeExtension' => [
'MediaWiki' => $constraint,
],
] ) );
}
public static function provideCheck() {
return [
// [ $wgVersion, constraint, expected ]
[ '1.25alpha', '>= 1.26', false ],
[ '1.25.0', '>= 1.26', false ],
[ '1.26alpha', '>= 1.26', true ],
[ '1.26alpha', '>= 1.26.0', true ],
[ '1.26alpha', '>= 1.26.0-stable', false ],
[ '1.26.0', '>= 1.26.0-stable', true ],
[ '1.26.1', '>= 1.26.0-stable', true ],
[ '1.27.1', '>= 1.26.0-stable', true ],
[ '1.26alpha', '>= 1.26.1', false ],
[ '1.26alpha', '>= 1.26alpha', true ],
[ '1.26alpha', '>= 1.25', true ],
[ '1.26.0-alpha.14', '>= 1.26.0-alpha.15', false ],
[ '1.26.0-alpha.14', '>= 1.26.0-alpha.10', true ],
[ '1.26.1', '>= 1.26.2, <=1.26.0', false ],
[ '1.26.1', '^1.26.2', false ],
// Accept anything for un-parsable version strings
[ '1.26mwf14', '== 1.25alpha', true ],
[ 'totallyinvalid', '== 1.0', true ],
];
}
/**
* @dataProvider provideType
*/
public function testType( $given, $expected ) {
$checker = new VersionChecker( '1.0.0' );
$checker->setLoadedExtensionsAndSkins( [
'FakeDependency' => [
'version' => '1.0.0',
],
'NoVersionGiven' => [],
] );
$this->assertEquals( $expected, $checker->checkArray( [
'FakeExtension' => $given,
] ) );
}
public static function provideType() {
return [
// valid type
[
[
'extensions' => [
'FakeDependency' => '1.0.0',
],
],
[],
],
[
[
'MediaWiki' => '1.0.0',
],
[],
],
[
[
'extensions' => [
'NoVersionGiven' => '*',
],
],
[],
],
[
[
'extensions' => [
'NoVersionGiven' => '1.0',
],
],
[
[
'incompatible' => 'FakeExtension',
'type' => 'incompatible-extensions',
'msg' => 'NoVersionGiven does not expose its version, but FakeExtension requires: 1.0.',
],
],
],
[
[
'extensions' => [
'Missing' => '*',
],
],
[
[
'missing' => 'Missing',
'type' => 'missing-extensions',
'msg' => 'FakeExtension requires Missing to be installed.',
],
],
],
[
[
'extensions' => [
'FakeDependency' => '2.0.0',
],
],
[
[
'incompatible' => 'FakeExtension',
'type' => 'incompatible-extensions',
// phpcs:ignore Generic.Files.LineLength.TooLong
'msg' => 'FakeExtension is not compatible with the current installed version of FakeDependency (1.0.0), it requires: 2.0.0.',
],
],
],
[
[
'skins' => [
'FakeSkin' => '*',
],
],
[
[
'missing' => 'FakeSkin',
'type' => 'missing-skins',
'msg' => 'FakeExtension requires FakeSkin to be installed.',
],
],
],
];
}
/**
* Check, if a non-parsable version constraint does not throw an exception or
* returns any error message.
*/
public function testInvalidConstraint() {
$checker = new VersionChecker( '1.0.0' );
$checker->setLoadedExtensionsAndSkins( [
'FakeDependency' => [
'version' => 'not really valid',
],
] );
$this->assertEquals( [
[
'type' => 'invalid-version',
'msg' => "FakeDependency does not have a valid version string.",
],
], $checker->checkArray( [
'FakeExtension' => [
'extensions' => [
'FakeDependency' => '1.24.3',
],
],
] ) );
$checker = new VersionChecker( '1.0.0' );
$checker->setLoadedExtensionsAndSkins( [
'FakeDependency' => [
'version' => '1.24.3',
],
] );
$this->setExpectedException( UnexpectedValueException::class );
$checker->checkArray( [
'FakeExtension' => [
'FakeDependency' => 'not really valid',
],
] );
}
/**
* T197478
*/
public function testInvalidDependency() {
$checker = new VersionChecker( '1.0.0' );
$this->setExpectedException( UnexpectedValueException::class,
'Dependency type skin unknown in FakeExtension' );
$this->assertEquals( [
[
'type' => 'invalid-version',
'msg' => 'FakeDependency does not have a valid version string.',
],
], $checker->checkArray( [
'FakeExtension' => [
'skin' => [
'FakeSkin' => '*',
],
],
] ) );
}
}
|
