1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
|
<?php
use MediaWiki\MediaWikiServices;
use Wikimedia\Rdbms\IDatabase;
class DatabaseLogEntryTest extends MediaWikiTestCase {
public function setUp() {
parent::setUp();
// These services cache their joins
MediaWikiServices::getInstance()->resetServiceForTesting( 'CommentStore' );
MediaWikiServices::getInstance()->resetServiceForTesting( 'ActorMigration' );
}
public function tearDown() {
parent::tearDown();
MediaWikiServices::getInstance()->resetServiceForTesting( 'CommentStore' );
MediaWikiServices::getInstance()->resetServiceForTesting( 'ActorMigration' );
}
/**
* @covers DatabaseLogEntry::newFromId
* @covers DatabaseLogEntry::getSelectQueryData
*
* @dataProvider provideNewFromId
*
* @param int $id
* @param array $selectFields
* @param string[]|null $row
* @param string[]|null $expectedFields
* @param string $migration
*/
public function testNewFromId( $id,
array $selectFields,
array $row = null,
array $expectedFields = null,
$migration
) {
$this->setMwGlobals( [
'wgCommentTableSchemaMigrationStage' => $migration,
'wgActorTableSchemaMigrationStage' => $migration,
] );
$row = $row ? (object)$row : null;
$db = $this->getMock( IDatabase::class );
$db->expects( self::once() )
->method( 'selectRow' )
->with( $selectFields['tables'],
$selectFields['fields'],
$selectFields['conds'],
'DatabaseLogEntry::newFromId',
$selectFields['options'],
$selectFields['join_conds']
)
->will( self::returnValue( $row ) );
/** @var IDatabase $db */
$logEntry = DatabaseLogEntry::newFromId( $id, $db );
if ( !$expectedFields ) {
self::assertNull( $logEntry, "Expected no log entry returned for id=$id" );
} else {
self::assertEquals( $id, $logEntry->getId() );
self::assertEquals( $expectedFields['type'], $logEntry->getType() );
self::assertEquals( $expectedFields['comment'], $logEntry->getComment() );
}
}
public function provideNewFromId() {
$oldTables = [
'tables' => [ 'logging', 'user' ],
'fields' => [
'log_id',
'log_type',
'log_action',
'log_timestamp',
'log_namespace',
'log_title',
'log_params',
'log_deleted',
'user_id',
'user_name',
'user_editcount',
'log_comment_text' => 'log_comment',
'log_comment_data' => 'NULL',
'log_comment_cid' => 'NULL',
'log_user' => 'log_user',
'log_user_text' => 'log_user_text',
'log_actor' => 'NULL',
],
'options' => [],
'join_conds' => [ 'user' => [ 'LEFT JOIN', 'user_id=log_user' ] ],
];
$newTables = [
'tables' => [
'logging',
'user',
'comment_log_comment' => 'comment',
'actor_log_user' => 'actor'
],
'fields' => [
'log_id',
'log_type',
'log_action',
'log_timestamp',
'log_namespace',
'log_title',
'log_params',
'log_deleted',
'user_id',
'user_name',
'user_editcount',
'log_comment_text' => 'comment_log_comment.comment_text',
'log_comment_data' => 'comment_log_comment.comment_data',
'log_comment_cid' => 'comment_log_comment.comment_id',
'log_user' => 'actor_log_user.actor_user',
'log_user_text' => 'actor_log_user.actor_name',
'log_actor' => 'log_actor',
],
'options' => [],
'join_conds' => [
'user' => [ 'LEFT JOIN', 'user_id=actor_log_user.actor_user' ],
'comment_log_comment' => [ 'JOIN', 'comment_log_comment.comment_id = log_comment_id' ],
'actor_log_user' => [ 'JOIN', 'actor_log_user.actor_id = log_actor' ],
],
];
return [
[
0,
$oldTables + [ 'conds' => [ 'log_id' => 0 ] ],
null,
null,
MIGRATION_OLD,
],
[
123,
$oldTables + [ 'conds' => [ 'log_id' => 123 ] ],
[
'log_id' => 123,
'log_type' => 'foobarize',
'log_comment_text' => 'test!',
'log_comment_data' => null,
],
[ 'type' => 'foobarize', 'comment' => 'test!' ],
MIGRATION_OLD,
],
[
567,
$newTables + [ 'conds' => [ 'log_id' => 567 ] ],
[
'log_id' => 567,
'log_type' => 'foobarize',
'log_comment_text' => 'test!',
'log_comment_data' => null,
],
[ 'type' => 'foobarize', 'comment' => 'test!' ],
MIGRATION_NEW,
],
];
}
}
|
