1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
|
<?php
namespace MediaWiki\Auth;
use Wikimedia\TestingAccessWrapper;
/**
* @group AuthManager
* @group Database
* @covers MediaWiki\Auth\ThrottlePreAuthenticationProvider
*/
class ThrottlePreAuthenticationProviderTest extends \MediaWikiTestCase {
public function testConstructor() {
$provider = new ThrottlePreAuthenticationProvider();
$providerPriv = TestingAccessWrapper::newFromObject( $provider );
$config = new \HashConfig( [
'AccountCreationThrottle' => [ [
'count' => 123,
'seconds' => 86400,
] ],
'PasswordAttemptThrottle' => [ [
'count' => 5,
'seconds' => 300,
] ],
] );
$provider->setConfig( $config );
$this->assertSame( [
'accountCreationThrottle' => [ [ 'count' => 123, 'seconds' => 86400 ] ],
'passwordAttemptThrottle' => [ [ 'count' => 5, 'seconds' => 300 ] ]
], $providerPriv->throttleSettings );
$accountCreationThrottle = TestingAccessWrapper::newFromObject(
$providerPriv->accountCreationThrottle );
$this->assertSame( [ [ 'count' => 123, 'seconds' => 86400 ] ],
$accountCreationThrottle->conditions );
$passwordAttemptThrottle = TestingAccessWrapper::newFromObject(
$providerPriv->passwordAttemptThrottle );
$this->assertSame( [ [ 'count' => 5, 'seconds' => 300 ] ],
$passwordAttemptThrottle->conditions );
$provider = new ThrottlePreAuthenticationProvider( [
'accountCreationThrottle' => [ [ 'count' => 43, 'seconds' => 10000 ] ],
'passwordAttemptThrottle' => [ [ 'count' => 11, 'seconds' => 100 ] ],
] );
$providerPriv = TestingAccessWrapper::newFromObject( $provider );
$config = new \HashConfig( [
'AccountCreationThrottle' => [ [
'count' => 123,
'seconds' => 86400,
] ],
'PasswordAttemptThrottle' => [ [
'count' => 5,
'seconds' => 300,
] ],
] );
$provider->setConfig( $config );
$this->assertSame( [
'accountCreationThrottle' => [ [ 'count' => 43, 'seconds' => 10000 ] ],
'passwordAttemptThrottle' => [ [ 'count' => 11, 'seconds' => 100 ] ],
], $providerPriv->throttleSettings );
$cache = new \HashBagOStuff();
$provider = new ThrottlePreAuthenticationProvider( [ 'cache' => $cache ] );
$providerPriv = TestingAccessWrapper::newFromObject( $provider );
$provider->setConfig( new \HashConfig( [
'AccountCreationThrottle' => [ [ 'count' => 1, 'seconds' => 1 ] ],
'PasswordAttemptThrottle' => [ [ 'count' => 1, 'seconds' => 1 ] ],
] ) );
$accountCreationThrottle = TestingAccessWrapper::newFromObject(
$providerPriv->accountCreationThrottle );
$this->assertSame( $cache, $accountCreationThrottle->cache );
$passwordAttemptThrottle = TestingAccessWrapper::newFromObject(
$providerPriv->passwordAttemptThrottle );
$this->assertSame( $cache, $passwordAttemptThrottle->cache );
}
public function testDisabled() {
$provider = new ThrottlePreAuthenticationProvider( [
'accountCreationThrottle' => [],
'passwordAttemptThrottle' => [],
'cache' => new \HashBagOStuff(),
] );
$provider->setLogger( new \Psr\Log\NullLogger() );
$provider->setConfig( new \HashConfig( [
'AccountCreationThrottle' => null,
'PasswordAttemptThrottle' => null,
] ) );
$provider->setManager( AuthManager::singleton() );
$this->assertEquals(
\StatusValue::newGood(),
$provider->testForAccountCreation(
\User::newFromName( 'Created' ),
\User::newFromName( 'Creator' ),
[]
)
);
$this->assertEquals(
\StatusValue::newGood(),
$provider->testForAuthentication( [] )
);
}
/**
* @dataProvider provideTestForAccountCreation
* @param string $creatorname
* @param bool $succeed
* @param bool $hook
*/
public function testTestForAccountCreation( $creatorname, $succeed, $hook ) {
$provider = new ThrottlePreAuthenticationProvider( [
'accountCreationThrottle' => [ [ 'count' => 2, 'seconds' => 86400 ] ],
'cache' => new \HashBagOStuff(),
] );
$provider->setLogger( new \Psr\Log\NullLogger() );
$provider->setConfig( new \HashConfig( [
'AccountCreationThrottle' => null,
'PasswordAttemptThrottle' => null,
] ) );
$provider->setManager( AuthManager::singleton() );
$user = \User::newFromName( 'RandomUser' );
$creator = \User::newFromName( $creatorname );
if ( $hook ) {
$mock = $this->getMockBuilder( stdClass::class )
->setMethods( [ 'onExemptFromAccountCreationThrottle' ] )
->getMock();
$mock->expects( $this->any() )->method( 'onExemptFromAccountCreationThrottle' )
->will( $this->returnValue( false ) );
$this->mergeMwGlobalArrayValue( 'wgHooks', [
'ExemptFromAccountCreationThrottle' => [ $mock ],
] );
}
$this->assertEquals(
true,
$provider->testForAccountCreation( $user, $creator, [] )->isOK(),
'attempt #1'
);
$this->assertEquals(
true,
$provider->testForAccountCreation( $user, $creator, [] )->isOK(),
'attempt #2'
);
$this->assertEquals(
$succeed ? true : false,
$provider->testForAccountCreation( $user, $creator, [] )->isOK(),
'attempt #3'
);
}
public static function provideTestForAccountCreation() {
return [
'Normal user' => [ 'NormalUser', false, false ],
'Sysop' => [ 'UTSysop', true, false ],
'Normal user with hook' => [ 'NormalUser', true, true ],
];
}
public function testTestForAuthentication() {
$provider = new ThrottlePreAuthenticationProvider( [
'passwordAttemptThrottle' => [ [ 'count' => 2, 'seconds' => 86400 ] ],
'cache' => new \HashBagOStuff(),
] );
$provider->setLogger( new \Psr\Log\NullLogger() );
$provider->setConfig( new \HashConfig( [
'AccountCreationThrottle' => null,
'PasswordAttemptThrottle' => null,
] ) );
$provider->setManager( AuthManager::singleton() );
$req = new UsernameAuthenticationRequest;
$req->username = 'SomeUser';
for ( $i = 1; $i <= 3; $i++ ) {
$status = $provider->testForAuthentication( [ $req ] );
$this->assertEquals( $i < 3, $status->isGood(), "attempt #$i" );
}
$this->assertCount( 1, $status->getErrors() );
$msg = new \Message( $status->getErrors()[0]['message'], $status->getErrors()[0]['params'] );
$this->assertEquals( 'login-throttled', $msg->getKey() );
$provider->postAuthentication( \User::newFromName( 'SomeUser' ),
AuthenticationResponse::newFail( wfMessage( 'foo' ) ) );
$this->assertFalse( $provider->testForAuthentication( [ $req ] )->isGood(), 'after FAIL' );
$provider->postAuthentication( \User::newFromName( 'SomeUser' ),
AuthenticationResponse::newPass() );
$this->assertTrue( $provider->testForAuthentication( [ $req ] )->isGood(), 'after PASS' );
$req1 = new UsernameAuthenticationRequest;
$req1->username = 'foo';
$req2 = new UsernameAuthenticationRequest;
$req2->username = 'bar';
$this->assertTrue( $provider->testForAuthentication( [ $req1, $req2 ] )->isGood() );
$req = new UsernameAuthenticationRequest;
$req->username = 'Some user';
$provider->testForAuthentication( [ $req ] );
$req->username = 'Some_user';
$provider->testForAuthentication( [ $req ] );
$req->username = 'some user';
$status = $provider->testForAuthentication( [ $req ] );
$this->assertFalse( $status->isGood(), 'denormalized usernames are normalized' );
}
public function testPostAuthentication() {
$provider = new ThrottlePreAuthenticationProvider( [
'passwordAttemptThrottle' => [],
'cache' => new \HashBagOStuff(),
] );
$provider->setLogger( new \TestLogger );
$provider->setConfig( new \HashConfig( [
'AccountCreationThrottle' => null,
'PasswordAttemptThrottle' => null,
] ) );
$provider->setManager( AuthManager::singleton() );
$provider->postAuthentication( \User::newFromName( 'SomeUser' ),
AuthenticationResponse::newPass() );
$provider = new ThrottlePreAuthenticationProvider( [
'passwordAttemptThrottle' => [ [ 'count' => 2, 'seconds' => 86400 ] ],
'cache' => new \HashBagOStuff(),
] );
$logger = new \TestLogger( true );
$provider->setLogger( $logger );
$provider->setConfig( new \HashConfig( [
'AccountCreationThrottle' => null,
'PasswordAttemptThrottle' => null,
] ) );
$provider->setManager( AuthManager::singleton() );
$provider->postAuthentication( \User::newFromName( 'SomeUser' ),
AuthenticationResponse::newPass() );
$this->assertSame( [
[ \Psr\Log\LogLevel::INFO, 'throttler data not found for {user}' ],
], $logger->getBuffer() );
}
}
|
