1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
|
<?php
/**
* Clean up user preferences from the database.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License along
* with this program; if not, write to the Free Software Foundation, Inc.,
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
* http://www.gnu.org/copyleft/gpl.html
*
* @file
* @author TyA <tya.wiki@gmail.com>
* @author Chad <chad@wikimedia.org>
* @see https://phabricator.wikimedia.org/T32976
* @ingroup Maintenance
*/
require_once __DIR__ . '/Maintenance.php';
/**
* Maintenance script that removes bogus preferences from the database.
*
* @ingroup Maintenance
*/
class CleanupPreferences extends Maintenance {
public function __construct() {
parent::__construct();
$this->mDescription = 'Clean up hidden preferences, removed preferences, and normalizes values';
$this->setBatchSize( 50 );
$this->addOption( 'dry-run', 'Print debug info instead of actually deleting' );
$this->addOption( 'hidden', 'Drop hidden preferences ($wgHiddenPrefs)' );
$this->addOption( 'unknown',
'Drop unknown preferences (not in $wgDefaultUserOptions or prefixed with "userjs-")' );
// TODO: actually implement this
// $this->addOption( 'bogus', 'Drop preferences that have invalid/unaccepted values' );
}
/**
* We will do this in three passes
* 1) The easiest is to drop the hidden preferences from the database. We
* don't actually want them
* 2) Drop preference keys that we don't know about. They could've been
* removed from core, provided by a now-disabled extension, or the result
* of a bug. We don't want them.
* 3) TODO: Normalize accepted preference values. This is the biggest part of the work.
* For each preference we know about, iterate over it and if it's got a
* limited set of accepted values (so it's not text, basically), make sure
* all values are in that range. Drop ones that aren't.
*/
public function execute() {
global $wgHiddenPrefs, $wgDefaultUserOptions;
$dbw = $this->getDB( DB_MASTER );
$didWork = false;
$hidden = $this->hasOption( 'hidden' );
$unknown = $this->hasOption( 'unknown' );
$bogus = $this->hasOption( 'bogus' );
if ( !$hidden && !$unknown && !$bogus ) {
$this->output( "Did not select one of --hidden, --unknown or --bogus, exiting\n" );
return;
}
// Remove hidden prefs. Iterate over them to avoid the IN on a large table
if ( $hidden ) {
if ( !$wgHiddenPrefs ) {
$this->output( "No hidden preferences, skipping\n" );
}
foreach ( $wgHiddenPrefs as $hiddenPref ) {
$this->deleteByWhere(
$dbw,
'Dropping hidden preferences',
[ 'up_property' => $hiddenPref ]
);
}
}
// Remove unknown preferences. Special-case 'userjs-' as we can't control those names.
if ( $unknown ) {
$where = [
'up_property NOT' . $dbw->buildLike( 'userjs-', $dbw->anyString() ),
'up_property NOT IN (' . $dbw->makeList( array_keys( $wgDefaultUserOptions ) ) . ')',
];
// Allow extensions to add to the where clause to prevent deletion of their own prefs.
Hooks::run( 'DeleteUnknownPreferences', [ &$where, $dbw ] );
$this->deleteByWhere( $dbw, 'Dropping unknown preferences', $where );
}
// Something something phase 3
if ( $bogus ) {
}
}
/**
*
*/
private function deleteByWhere( $dbw, $startMessage, $where ) {
$this->output( $startMessage . "...\n" );
$total = 0;
while ( true ) {
$res = $dbw->select(
'user_properties',
'*', // The table lacks a primary key, so select the whole row
$where,
__METHOD__,
[ 'LIMIT' => $this->mBatchSize ]
);
$numRows = $res->numRows();
$total += $numRows;
if ( $res->numRows() <= 0 ) {
// All done!
$this->output( "DONE! (handled $total entries)\n" );
break;
}
// Progress or something
$this->output( "..doing $numRows entries\n" );
// Delete our batch, then wait
foreach ( $res as $row ) {
if ( $this->hasOption( 'dry-run' ) ) {
$this->output(
" DRY RUN, would drop: " .
"[up_user] => '{$row->up_user}' " .
"[up_property] => '{$row->up_property}' " .
"[up_value] => '{$row->up_value}'\n"
);
continue;
}
$this->beginTransaction( $dbw, __METHOD__ );
$dbw->delete(
'user_properties',
[
'up_user' => $row->up_user,
'up_property' => $row->up_property,
'up_value' => $row->up_value,
],
__METHOD__
);
$this->commitTransaction( $dbw, __METHOD__ );
}
}
}
}
$maintClass = CleanupPreferences::class; // Tells it to run the class
require_once RUN_MAINTENANCE_IF_MAIN;
|
