diff options
Diffstat (limited to 'www/wiki/tests/phpunit/includes/user')
8 files changed, 2558 insertions, 0 deletions
diff --git a/www/wiki/tests/phpunit/includes/user/BotPasswordTest.php b/www/wiki/tests/phpunit/includes/user/BotPasswordTest.php new file mode 100644 index 00000000..3bbc2dfa --- /dev/null +++ b/www/wiki/tests/phpunit/includes/user/BotPasswordTest.php @@ -0,0 +1,420 @@ +<?php + +use MediaWiki\Session\SessionManager; +use Wikimedia\ScopedCallback; +use Wikimedia\TestingAccessWrapper; + +/** + * @covers BotPassword + * @group Database + */ +class BotPasswordTest extends MediaWikiTestCase { + + /** @var TestUser */ + private $testUser; + + /** @var string */ + private $testUserName; + + protected function setUp() { + parent::setUp(); + + $this->setMwGlobals( [ + 'wgEnableBotPasswords' => true, + 'wgBotPasswordsDatabase' => false, + 'wgCentralIdLookupProvider' => 'BotPasswordTest OkMock', + 'wgGrantPermissions' => [ + 'test' => [ 'read' => true ], + ], + 'wgUserrightsInterwikiDelimiter' => '@', + ] ); + + $this->testUser = $this->getMutableTestUser(); + $this->testUserName = $this->testUser->getUser()->getName(); + + $mock1 = $this->getMockForAbstractClass( CentralIdLookup::class ); + $mock1->expects( $this->any() )->method( 'isAttached' ) + ->will( $this->returnValue( true ) ); + $mock1->expects( $this->any() )->method( 'lookupUserNames' ) + ->will( $this->returnValue( [ $this->testUserName => 42, 'UTDummy' => 43, 'UTInvalid' => 0 ] ) ); + $mock1->expects( $this->never() )->method( 'lookupCentralIds' ); + + $mock2 = $this->getMockForAbstractClass( CentralIdLookup::class ); + $mock2->expects( $this->any() )->method( 'isAttached' ) + ->will( $this->returnValue( false ) ); + $mock2->expects( $this->any() )->method( 'lookupUserNames' ) + ->will( $this->returnArgument( 0 ) ); + $mock2->expects( $this->never() )->method( 'lookupCentralIds' ); + + $this->mergeMwGlobalArrayValue( 'wgCentralIdLookupProviders', [ + 'BotPasswordTest OkMock' => [ 'factory' => function () use ( $mock1 ) { + return $mock1; + } ], + 'BotPasswordTest FailMock' => [ 'factory' => function () use ( $mock2 ) { + return $mock2; + } ], + ] ); + + CentralIdLookup::resetCache(); + } + + public function addDBData() { + $passwordFactory = new \PasswordFactory(); + $passwordFactory->init( \RequestContext::getMain()->getConfig() ); + $passwordHash = $passwordFactory->newFromPlaintext( 'foobaz' ); + + $dbw = wfGetDB( DB_MASTER ); + $dbw->delete( + 'bot_passwords', + [ 'bp_user' => [ 42, 43 ], 'bp_app_id' => 'BotPassword' ], + __METHOD__ + ); + $dbw->insert( + 'bot_passwords', + [ + [ + 'bp_user' => 42, + 'bp_app_id' => 'BotPassword', + 'bp_password' => $passwordHash->toString(), + 'bp_token' => 'token!', + 'bp_restrictions' => '{"IPAddresses":["127.0.0.0/8"]}', + 'bp_grants' => '["test"]', + ], + [ + 'bp_user' => 43, + 'bp_app_id' => 'BotPassword', + 'bp_password' => $passwordHash->toString(), + 'bp_token' => 'token!', + 'bp_restrictions' => '{"IPAddresses":["127.0.0.0/8"]}', + 'bp_grants' => '["test"]', + ], + ], + __METHOD__ + ); + } + + public function testBasics() { + $user = $this->testUser->getUser(); + $bp = BotPassword::newFromUser( $user, 'BotPassword' ); + $this->assertInstanceOf( BotPassword::class, $bp ); + $this->assertTrue( $bp->isSaved() ); + $this->assertSame( 42, $bp->getUserCentralId() ); + $this->assertSame( 'BotPassword', $bp->getAppId() ); + $this->assertSame( 'token!', trim( $bp->getToken(), " \0" ) ); + $this->assertEquals( '{"IPAddresses":["127.0.0.0/8"]}', $bp->getRestrictions()->toJson() ); + $this->assertSame( [ 'test' ], $bp->getGrants() ); + + $this->assertNull( BotPassword::newFromUser( $user, 'DoesNotExist' ) ); + + $this->setMwGlobals( [ + 'wgCentralIdLookupProvider' => 'BotPasswordTest FailMock' + ] ); + $this->assertNull( BotPassword::newFromUser( $user, 'BotPassword' ) ); + + $this->assertSame( '@', BotPassword::getSeparator() ); + $this->setMwGlobals( [ + 'wgUserrightsInterwikiDelimiter' => '#', + ] ); + $this->assertSame( '#', BotPassword::getSeparator() ); + } + + public function testUnsaved() { + $user = $this->testUser->getUser(); + $bp = BotPassword::newUnsaved( [ + 'user' => $user, + 'appId' => 'DoesNotExist' + ] ); + $this->assertInstanceOf( BotPassword::class, $bp ); + $this->assertFalse( $bp->isSaved() ); + $this->assertSame( 42, $bp->getUserCentralId() ); + $this->assertSame( 'DoesNotExist', $bp->getAppId() ); + $this->assertEquals( MWRestrictions::newDefault(), $bp->getRestrictions() ); + $this->assertSame( [], $bp->getGrants() ); + + $bp = BotPassword::newUnsaved( [ + 'username' => 'UTDummy', + 'appId' => 'DoesNotExist2', + 'restrictions' => MWRestrictions::newFromJson( '{"IPAddresses":["127.0.0.0/8"]}' ), + 'grants' => [ 'test' ], + ] ); + $this->assertInstanceOf( BotPassword::class, $bp ); + $this->assertFalse( $bp->isSaved() ); + $this->assertSame( 43, $bp->getUserCentralId() ); + $this->assertSame( 'DoesNotExist2', $bp->getAppId() ); + $this->assertEquals( '{"IPAddresses":["127.0.0.0/8"]}', $bp->getRestrictions()->toJson() ); + $this->assertSame( [ 'test' ], $bp->getGrants() ); + + $user = $this->testUser->getUser(); + $bp = BotPassword::newUnsaved( [ + 'centralId' => 45, + 'appId' => 'DoesNotExist' + ] ); + $this->assertInstanceOf( BotPassword::class, $bp ); + $this->assertFalse( $bp->isSaved() ); + $this->assertSame( 45, $bp->getUserCentralId() ); + $this->assertSame( 'DoesNotExist', $bp->getAppId() ); + + $user = $this->testUser->getUser(); + $bp = BotPassword::newUnsaved( [ + 'user' => $user, + 'appId' => 'BotPassword' + ] ); + $this->assertInstanceOf( BotPassword::class, $bp ); + $this->assertFalse( $bp->isSaved() ); + + $this->assertNull( BotPassword::newUnsaved( [ + 'user' => $user, + 'appId' => '', + ] ) ); + $this->assertNull( BotPassword::newUnsaved( [ + 'user' => $user, + 'appId' => str_repeat( 'X', BotPassword::APPID_MAXLENGTH + 1 ), + ] ) ); + $this->assertNull( BotPassword::newUnsaved( [ + 'user' => $this->testUserName, + 'appId' => 'Ok', + ] ) ); + $this->assertNull( BotPassword::newUnsaved( [ + 'username' => 'UTInvalid', + 'appId' => 'Ok', + ] ) ); + $this->assertNull( BotPassword::newUnsaved( [ + 'appId' => 'Ok', + ] ) ); + } + + public function testGetPassword() { + $bp = TestingAccessWrapper::newFromObject( BotPassword::newFromCentralId( 42, 'BotPassword' ) ); + + $password = $bp->getPassword(); + $this->assertInstanceOf( Password::class, $password ); + $this->assertTrue( $password->equals( 'foobaz' ) ); + + $bp->centralId = 44; + $password = $bp->getPassword(); + $this->assertInstanceOf( InvalidPassword::class, $password ); + + $bp = TestingAccessWrapper::newFromObject( BotPassword::newFromCentralId( 42, 'BotPassword' ) ); + $dbw = wfGetDB( DB_MASTER ); + $dbw->update( + 'bot_passwords', + [ 'bp_password' => 'garbage' ], + [ 'bp_user' => 42, 'bp_app_id' => 'BotPassword' ], + __METHOD__ + ); + $password = $bp->getPassword(); + $this->assertInstanceOf( InvalidPassword::class, $password ); + } + + public function testInvalidateAllPasswordsForUser() { + $bp1 = TestingAccessWrapper::newFromObject( BotPassword::newFromCentralId( 42, 'BotPassword' ) ); + $bp2 = TestingAccessWrapper::newFromObject( BotPassword::newFromCentralId( 43, 'BotPassword' ) ); + + $this->assertNotInstanceOf( InvalidPassword::class, $bp1->getPassword(), 'sanity check' ); + $this->assertNotInstanceOf( InvalidPassword::class, $bp2->getPassword(), 'sanity check' ); + BotPassword::invalidateAllPasswordsForUser( $this->testUserName ); + $this->assertInstanceOf( InvalidPassword::class, $bp1->getPassword() ); + $this->assertNotInstanceOf( InvalidPassword::class, $bp2->getPassword() ); + + $bp = TestingAccessWrapper::newFromObject( BotPassword::newFromCentralId( 42, 'BotPassword' ) ); + $this->assertInstanceOf( InvalidPassword::class, $bp->getPassword() ); + } + + public function testRemoveAllPasswordsForUser() { + $this->assertNotNull( BotPassword::newFromCentralId( 42, 'BotPassword' ), 'sanity check' ); + $this->assertNotNull( BotPassword::newFromCentralId( 43, 'BotPassword' ), 'sanity check' ); + + BotPassword::removeAllPasswordsForUser( $this->testUserName ); + + $this->assertNull( BotPassword::newFromCentralId( 42, 'BotPassword' ) ); + $this->assertNotNull( BotPassword::newFromCentralId( 43, 'BotPassword' ) ); + } + + /** + * @dataProvider provideCanonicalizeLoginData + */ + public function testCanonicalizeLoginData( $username, $password, $expectedResult ) { + $result = BotPassword::canonicalizeLoginData( $username, $password ); + if ( is_array( $expectedResult ) ) { + $this->assertArrayEquals( $expectedResult, $result, true, true ); + } else { + $this->assertSame( $expectedResult, $result ); + } + } + + public function provideCanonicalizeLoginData() { + return [ + [ 'user', 'pass', false ], + [ 'user', 'abc@def', false ], + [ 'legacy@user', 'pass', false ], + [ 'user@bot', '12345678901234567890123456789012', + [ 'user@bot', '12345678901234567890123456789012', true ] ], + [ 'user', 'bot@12345678901234567890123456789012', + [ 'user@bot', '12345678901234567890123456789012', true ] ], + [ 'user', 'bot@12345678901234567890123456789012345', + [ 'user@bot', '12345678901234567890123456789012345', true ] ], + [ 'user', 'bot@x@12345678901234567890123456789012', + [ 'user@bot@x', '12345678901234567890123456789012', true ] ], + ]; + } + + public function testLogin() { + // Test failure when bot passwords aren't enabled + $this->setMwGlobals( 'wgEnableBotPasswords', false ); + $status = BotPassword::login( "{$this->testUserName}@BotPassword", 'foobaz', new FauxRequest ); + $this->assertEquals( Status::newFatal( 'botpasswords-disabled' ), $status ); + $this->setMwGlobals( 'wgEnableBotPasswords', true ); + + // Test failure when BotPasswordSessionProvider isn't configured + $manager = new SessionManager( [ + 'logger' => new Psr\Log\NullLogger, + 'store' => new EmptyBagOStuff, + ] ); + $reset = MediaWiki\Session\TestUtils::setSessionManagerSingleton( $manager ); + $this->assertNull( + $manager->getProvider( MediaWiki\Session\BotPasswordSessionProvider::class ), + 'sanity check' + ); + $status = BotPassword::login( "{$this->testUserName}@BotPassword", 'foobaz', new FauxRequest ); + $this->assertEquals( Status::newFatal( 'botpasswords-no-provider' ), $status ); + ScopedCallback::consume( $reset ); + + // Now configure BotPasswordSessionProvider for further tests... + $mainConfig = RequestContext::getMain()->getConfig(); + $config = new HashConfig( [ + 'SessionProviders' => $mainConfig->get( 'SessionProviders' ) + [ + MediaWiki\Session\BotPasswordSessionProvider::class => [ + 'class' => MediaWiki\Session\BotPasswordSessionProvider::class, + 'args' => [ [ 'priority' => 40 ] ], + ] + ], + ] ); + $manager = new SessionManager( [ + 'config' => new MultiConfig( [ $config, RequestContext::getMain()->getConfig() ] ), + 'logger' => new Psr\Log\NullLogger, + 'store' => new EmptyBagOStuff, + ] ); + $reset = MediaWiki\Session\TestUtils::setSessionManagerSingleton( $manager ); + + // No "@"-thing in the username + $status = BotPassword::login( $this->testUserName, 'foobaz', new FauxRequest ); + $this->assertEquals( Status::newFatal( 'botpasswords-invalid-name', '@' ), $status ); + + // No base user + $status = BotPassword::login( 'UTDummy@BotPassword', 'foobaz', new FauxRequest ); + $this->assertEquals( Status::newFatal( 'nosuchuser', 'UTDummy' ), $status ); + + // No bot password + $status = BotPassword::login( "{$this->testUserName}@DoesNotExist", 'foobaz', new FauxRequest ); + $this->assertEquals( + Status::newFatal( 'botpasswords-not-exist', $this->testUserName, 'DoesNotExist' ), + $status + ); + + // Failed restriction + $request = $this->getMockBuilder( FauxRequest::class ) + ->setMethods( [ 'getIP' ] ) + ->getMock(); + $request->expects( $this->any() )->method( 'getIP' ) + ->will( $this->returnValue( '10.0.0.1' ) ); + $status = BotPassword::login( "{$this->testUserName}@BotPassword", 'foobaz', $request ); + $this->assertEquals( Status::newFatal( 'botpasswords-restriction-failed' ), $status ); + + // Wrong password + $status = BotPassword::login( + "{$this->testUserName}@BotPassword", $this->testUser->getPassword(), new FauxRequest ); + $this->assertEquals( Status::newFatal( 'wrongpassword' ), $status ); + + // Success! + $request = new FauxRequest; + $this->assertNotInstanceOf( + MediaWiki\Session\BotPasswordSessionProvider::class, + $request->getSession()->getProvider(), + 'sanity check' + ); + $status = BotPassword::login( "{$this->testUserName}@BotPassword", 'foobaz', $request ); + $this->assertInstanceOf( Status::class, $status ); + $this->assertTrue( $status->isGood() ); + $session = $status->getValue(); + $this->assertInstanceOf( MediaWiki\Session\Session::class, $session ); + $this->assertInstanceOf( + MediaWiki\Session\BotPasswordSessionProvider::class, $session->getProvider() + ); + $this->assertSame( $session->getId(), $request->getSession()->getId() ); + + ScopedCallback::consume( $reset ); + } + + /** + * @dataProvider provideSave + * @param string|null $password + */ + public function testSave( $password ) { + $passwordFactory = new \PasswordFactory(); + $passwordFactory->init( \RequestContext::getMain()->getConfig() ); + + $bp = BotPassword::newUnsaved( [ + 'centralId' => 42, + 'appId' => 'TestSave', + 'restrictions' => MWRestrictions::newFromJson( '{"IPAddresses":["127.0.0.0/8"]}' ), + 'grants' => [ 'test' ], + ] ); + $this->assertFalse( $bp->isSaved(), 'sanity check' ); + $this->assertNull( + BotPassword::newFromCentralId( 42, 'TestSave', BotPassword::READ_LATEST ), 'sanity check' + ); + + $passwordHash = $password ? $passwordFactory->newFromPlaintext( $password ) : null; + $this->assertFalse( $bp->save( 'update', $passwordHash ) ); + $this->assertTrue( $bp->save( 'insert', $passwordHash ) ); + $bp2 = BotPassword::newFromCentralId( 42, 'TestSave', BotPassword::READ_LATEST ); + $this->assertInstanceOf( BotPassword::class, $bp2 ); + $this->assertEquals( $bp->getUserCentralId(), $bp2->getUserCentralId() ); + $this->assertEquals( $bp->getAppId(), $bp2->getAppId() ); + $this->assertEquals( $bp->getToken(), $bp2->getToken() ); + $this->assertEquals( $bp->getRestrictions(), $bp2->getRestrictions() ); + $this->assertEquals( $bp->getGrants(), $bp2->getGrants() ); + $pw = TestingAccessWrapper::newFromObject( $bp )->getPassword(); + if ( $password === null ) { + $this->assertInstanceOf( InvalidPassword::class, $pw ); + } else { + $this->assertTrue( $pw->equals( $password ) ); + } + + $token = $bp->getToken(); + $this->assertEquals( 42, $bp->getUserCentralId() ); + $this->assertEquals( 'TestSave', $bp->getAppId() ); + $this->assertFalse( $bp->save( 'insert' ) ); + $this->assertTrue( $bp->save( 'update' ) ); + $this->assertNotEquals( $token, $bp->getToken() ); + $bp2 = BotPassword::newFromCentralId( 42, 'TestSave', BotPassword::READ_LATEST ); + $this->assertInstanceOf( BotPassword::class, $bp2 ); + $this->assertEquals( $bp->getToken(), $bp2->getToken() ); + $pw = TestingAccessWrapper::newFromObject( $bp )->getPassword(); + if ( $password === null ) { + $this->assertInstanceOf( InvalidPassword::class, $pw ); + } else { + $this->assertTrue( $pw->equals( $password ) ); + } + + $passwordHash = $passwordFactory->newFromPlaintext( 'XXX' ); + $token = $bp->getToken(); + $this->assertTrue( $bp->save( 'update', $passwordHash ) ); + $this->assertNotEquals( $token, $bp->getToken() ); + $pw = TestingAccessWrapper::newFromObject( $bp )->getPassword(); + $this->assertTrue( $pw->equals( 'XXX' ) ); + + $this->assertTrue( $bp->delete() ); + $this->assertFalse( $bp->isSaved() ); + $this->assertNull( BotPassword::newFromCentralId( 42, 'TestSave', BotPassword::READ_LATEST ) ); + + $this->assertFalse( $bp->save( 'foobar' ) ); + } + + public static function provideSave() { + return [ + [ null ], + [ 'foobar' ], + ]; + } +} diff --git a/www/wiki/tests/phpunit/includes/user/CentralIdLookupTest.php b/www/wiki/tests/phpunit/includes/user/CentralIdLookupTest.php new file mode 100644 index 00000000..dc9fe2ad --- /dev/null +++ b/www/wiki/tests/phpunit/includes/user/CentralIdLookupTest.php @@ -0,0 +1,183 @@ +<?php + +use Wikimedia\TestingAccessWrapper; + +/** + * @covers CentralIdLookup + * @group Database + */ +class CentralIdLookupTest extends MediaWikiTestCase { + + public function testFactory() { + $mock = $this->getMockForAbstractClass( CentralIdLookup::class ); + + $this->setMwGlobals( [ + 'wgCentralIdLookupProviders' => [ + 'local' => [ 'class' => LocalIdLookup::class ], + 'local2' => [ 'class' => LocalIdLookup::class ], + 'mock' => [ 'factory' => function () use ( $mock ) { + return $mock; + } ], + 'bad' => [ 'class' => stdClass::class ], + ], + 'wgCentralIdLookupProvider' => 'mock', + ] ); + + $this->assertSame( $mock, CentralIdLookup::factory() ); + $this->assertSame( $mock, CentralIdLookup::factory( 'mock' ) ); + $this->assertSame( 'mock', $mock->getProviderId() ); + + $local = CentralIdLookup::factory( 'local' ); + $this->assertNotSame( $mock, $local ); + $this->assertInstanceOf( LocalIdLookup::class, $local ); + $this->assertSame( $local, CentralIdLookup::factory( 'local' ) ); + $this->assertSame( 'local', $local->getProviderId() ); + + $local2 = CentralIdLookup::factory( 'local2' ); + $this->assertNotSame( $local, $local2 ); + $this->assertInstanceOf( LocalIdLookup::class, $local2 ); + $this->assertSame( 'local2', $local2->getProviderId() ); + + $this->assertNull( CentralIdLookup::factory( 'unconfigured' ) ); + $this->assertNull( CentralIdLookup::factory( 'bad' ) ); + } + + public function testCheckAudience() { + $mock = TestingAccessWrapper::newFromObject( + $this->getMockForAbstractClass( CentralIdLookup::class ) + ); + + $user = static::getTestSysop()->getUser(); + $this->assertSame( $user, $mock->checkAudience( $user ) ); + + $user = $mock->checkAudience( CentralIdLookup::AUDIENCE_PUBLIC ); + $this->assertInstanceOf( User::class, $user ); + $this->assertSame( 0, $user->getId() ); + + $this->assertNull( $mock->checkAudience( CentralIdLookup::AUDIENCE_RAW ) ); + + try { + $mock->checkAudience( 100 ); + $this->fail( 'Expected exception not thrown' ); + } catch ( InvalidArgumentException $ex ) { + $this->assertSame( 'Invalid audience', $ex->getMessage() ); + } + } + + public function testNameFromCentralId() { + $mock = $this->getMockForAbstractClass( CentralIdLookup::class ); + $mock->expects( $this->once() )->method( 'lookupCentralIds' ) + ->with( + $this->equalTo( [ 15 => null ] ), + $this->equalTo( CentralIdLookup::AUDIENCE_RAW ), + $this->equalTo( CentralIdLookup::READ_LATEST ) + ) + ->will( $this->returnValue( [ 15 => 'FooBar' ] ) ); + + $this->assertSame( + 'FooBar', + $mock->nameFromCentralId( 15, CentralIdLookup::AUDIENCE_RAW, CentralIdLookup::READ_LATEST ) + ); + } + + /** + * @dataProvider provideLocalUserFromCentralId + * @param string $name + * @param bool $succeeds + */ + public function testLocalUserFromCentralId( $name, $succeeds ) { + $mock = $this->getMockForAbstractClass( CentralIdLookup::class ); + $mock->expects( $this->any() )->method( 'isAttached' ) + ->will( $this->returnValue( true ) ); + $mock->expects( $this->once() )->method( 'lookupCentralIds' ) + ->with( + $this->equalTo( [ 42 => null ] ), + $this->equalTo( CentralIdLookup::AUDIENCE_RAW ), + $this->equalTo( CentralIdLookup::READ_LATEST ) + ) + ->will( $this->returnValue( [ 42 => $name ] ) ); + + $user = $mock->localUserFromCentralId( + 42, CentralIdLookup::AUDIENCE_RAW, CentralIdLookup::READ_LATEST + ); + if ( $succeeds ) { + $this->assertInstanceOf( User::class, $user ); + $this->assertSame( $name, $user->getName() ); + } else { + $this->assertNull( $user ); + } + + $mock = $this->getMockForAbstractClass( CentralIdLookup::class ); + $mock->expects( $this->any() )->method( 'isAttached' ) + ->will( $this->returnValue( false ) ); + $mock->expects( $this->once() )->method( 'lookupCentralIds' ) + ->with( + $this->equalTo( [ 42 => null ] ), + $this->equalTo( CentralIdLookup::AUDIENCE_RAW ), + $this->equalTo( CentralIdLookup::READ_LATEST ) + ) + ->will( $this->returnValue( [ 42 => $name ] ) ); + $this->assertNull( + $mock->localUserFromCentralId( 42, CentralIdLookup::AUDIENCE_RAW, CentralIdLookup::READ_LATEST ) + ); + } + + public static function provideLocalUserFromCentralId() { + return [ + [ 'UTSysop', true ], + [ 'UTDoesNotExist', false ], + [ null, false ], + [ '', false ], + [ '<X>', false ], + ]; + } + + public function testCentralIdFromName() { + $mock = $this->getMockForAbstractClass( CentralIdLookup::class ); + $mock->expects( $this->once() )->method( 'lookupUserNames' ) + ->with( + $this->equalTo( [ 'FooBar' => 0 ] ), + $this->equalTo( CentralIdLookup::AUDIENCE_RAW ), + $this->equalTo( CentralIdLookup::READ_LATEST ) + ) + ->will( $this->returnValue( [ 'FooBar' => 23 ] ) ); + + $this->assertSame( + 23, + $mock->centralIdFromName( 'FooBar', CentralIdLookup::AUDIENCE_RAW, CentralIdLookup::READ_LATEST ) + ); + } + + public function testCentralIdFromLocalUser() { + $mock = $this->getMockForAbstractClass( CentralIdLookup::class ); + $mock->expects( $this->any() )->method( 'isAttached' ) + ->will( $this->returnValue( true ) ); + $mock->expects( $this->once() )->method( 'lookupUserNames' ) + ->with( + $this->equalTo( [ 'FooBar' => 0 ] ), + $this->equalTo( CentralIdLookup::AUDIENCE_RAW ), + $this->equalTo( CentralIdLookup::READ_LATEST ) + ) + ->will( $this->returnValue( [ 'FooBar' => 23 ] ) ); + + $this->assertSame( + 23, + $mock->centralIdFromLocalUser( + User::newFromName( 'FooBar' ), CentralIdLookup::AUDIENCE_RAW, CentralIdLookup::READ_LATEST + ) + ); + + $mock = $this->getMockForAbstractClass( CentralIdLookup::class ); + $mock->expects( $this->any() )->method( 'isAttached' ) + ->will( $this->returnValue( false ) ); + $mock->expects( $this->never() )->method( 'lookupUserNames' ); + + $this->assertSame( + 0, + $mock->centralIdFromLocalUser( + User::newFromName( 'FooBar' ), CentralIdLookup::AUDIENCE_RAW, CentralIdLookup::READ_LATEST + ) + ); + } + +} diff --git a/www/wiki/tests/phpunit/includes/user/ExternalUserNamesTest.php b/www/wiki/tests/phpunit/includes/user/ExternalUserNamesTest.php new file mode 100644 index 00000000..429bda46 --- /dev/null +++ b/www/wiki/tests/phpunit/includes/user/ExternalUserNamesTest.php @@ -0,0 +1,131 @@ +<?php + +use MediaWiki\Interwiki\InterwikiLookup; + +/** + * @covers ExternalUserNames + */ +class ExternalUserNamesTest extends MediaWikiTestCase { + + public function provideGetUserLinkTitle() { + return [ + [ 'valid:>User1', Title::makeTitle( NS_MAIN, ':User:User1', '', 'valid' ) ], + [ + 'valid:valid:>User1', + Title::makeTitle( NS_MAIN, 'valid::User:User1', '', 'valid' ) + ], + [ + '127.0.0.1', + Title::makeTitle( NS_SPECIAL, 'Contributions/127.0.0.1', '', '' ) + ], + [ 'invalid:>User1', null ] + ]; + } + + /** + * @covers ExternalUserNames::getUserLinkTitle + * @dataProvider provideGetUserLinkTitle + */ + public function testGetUserLinkTitle( $username, $expected ) { + $interwikiLookupMock = $this->getMockBuilder( InterwikiLookup::class ) + ->getMock(); + + $interwikiValueMap = [ + [ 'valid', true ], + [ 'invalid', false ] + ]; + $interwikiLookupMock->expects( $this->any() ) + ->method( 'isValidInterwiki' ) + ->will( $this->returnValueMap( $interwikiValueMap ) ); + + $this->setService( 'InterwikiLookup', $interwikiLookupMock ); + + $this->assertEquals( + $expected, + ExternalUserNames::getUserLinkTitle( $username ) + ); + } + + public function provideApplyPrefix() { + return [ + [ 'User1', 'prefix', 'prefix>User1' ], + [ 'User1', 'prefix:>', 'prefix>User1' ], + [ 'User1', 'prefix:', 'prefix>User1' ], + ]; + } + + /** + * @covers ExternalUserNames::applyPrefix + * @dataProvider provideApplyPrefix + */ + public function testApplyPrefix( $username, $prefix, $expected ) { + $externalUserNames = new ExternalUserNames( $prefix, true ); + + $this->assertSame( + $expected, + $externalUserNames->applyPrefix( $username ) + ); + } + + public function provideAddPrefix() { + return [ + [ 'User1', 'prefix', 'prefix>User1' ], + [ 'User2', 'prefix2', 'prefix2>User2' ], + [ 'User3', 'prefix3', 'prefix3>User3' ], + ]; + } + + /** + * @covers ExternalUserNames::addPrefix + * @dataProvider provideAddPrefix + */ + public function testAddPrefix( $username, $prefix, $expected ) { + $externalUserNames = new ExternalUserNames( $prefix, true ); + + $this->assertSame( + $expected, + $externalUserNames->addPrefix( $username ) + ); + } + + public function provideIsExternal() { + return [ + [ 'User1', false ], + [ '>User1', true ], + [ 'prefix>User1', true ], + [ 'prefix:>User1', true ], + ]; + } + + /** + * @covers ExternalUserNames::isExternal + * @dataProvider provideIsExternal + */ + public function testIsExternal( $username, $expected ) { + $this->assertSame( + $expected, + ExternalUserNames::isExternal( $username ) + ); + } + + public function provideGetLocal() { + return [ + [ 'User1', 'User1' ], + [ '>User2', 'User2' ], + [ 'prefix>User3', 'User3' ], + [ 'prefix:>User4', 'User4' ], + ]; + } + + /** + * @covers ExternalUserNames::getLocal + * @dataProvider provideGetLocal + */ + public function testGetLocal( $username, $expected ) { + $this->assertSame( + $expected, + ExternalUserNames::getLocal( $username ) + ); + } + +} diff --git a/www/wiki/tests/phpunit/includes/user/LocalIdLookupTest.php b/www/wiki/tests/phpunit/includes/user/LocalIdLookupTest.php new file mode 100644 index 00000000..c91d8e0c --- /dev/null +++ b/www/wiki/tests/phpunit/includes/user/LocalIdLookupTest.php @@ -0,0 +1,156 @@ +<?php + +/** + * @covers LocalIdLookup + * @group Database + */ +class LocalIdLookupTest extends MediaWikiTestCase { + private $localUsers = []; + + protected function setUp() { + global $wgGroupPermissions; + + parent::setUp(); + + $this->stashMwGlobals( [ 'wgGroupPermissions' ] ); + $wgGroupPermissions['local-id-lookup-test']['hideuser'] = true; + } + + public function addDBData() { + for ( $i = 1; $i <= 4; $i++ ) { + $this->localUsers[] = $this->getMutableTestUser()->getUser(); + } + + $sysop = static::getTestSysop()->getUser(); + + $block = new Block( [ + 'address' => $this->localUsers[2]->getName(), + 'by' => $sysop->getId(), + 'reason' => __METHOD__, + 'expiry' => '1 day', + 'hideName' => false, + ] ); + $block->insert(); + + $block = new Block( [ + 'address' => $this->localUsers[3]->getName(), + 'by' => $sysop->getId(), + 'reason' => __METHOD__, + 'expiry' => '1 day', + 'hideName' => true, + ] ); + $block->insert(); + } + + public function getLookupUser() { + return static::getTestUser( [ 'local-id-lookup-test' ] )->getUser(); + } + + public function testLookupCentralIds() { + $lookup = new LocalIdLookup(); + + $user1 = $this->getLookupUser(); + $user2 = User::newFromName( 'UTLocalIdLookup2' ); + + $this->assertTrue( $user1->isAllowed( 'hideuser' ), 'sanity check' ); + $this->assertFalse( $user2->isAllowed( 'hideuser' ), 'sanity check' ); + + $this->assertSame( [], $lookup->lookupCentralIds( [] ) ); + + $expect = []; + foreach ( $this->localUsers as $localUser ) { + $expect[$localUser->getId()] = $localUser->getName(); + } + $expect[12345] = 'X'; + ksort( $expect ); + + $expect2 = $expect; + $expect2[$this->localUsers[3]->getId()] = ''; + + $arg = array_fill_keys( array_keys( $expect ), 'X' ); + + $this->assertSame( $expect2, $lookup->lookupCentralIds( $arg ) ); + $this->assertSame( $expect, $lookup->lookupCentralIds( $arg, CentralIdLookup::AUDIENCE_RAW ) ); + $this->assertSame( $expect, $lookup->lookupCentralIds( $arg, $user1 ) ); + $this->assertSame( $expect2, $lookup->lookupCentralIds( $arg, $user2 ) ); + } + + public function testLookupUserNames() { + $lookup = new LocalIdLookup(); + $user1 = $this->getLookupUser(); + $user2 = User::newFromName( 'UTLocalIdLookup2' ); + + $this->assertTrue( $user1->isAllowed( 'hideuser' ), 'sanity check' ); + $this->assertFalse( $user2->isAllowed( 'hideuser' ), 'sanity check' ); + + $this->assertSame( [], $lookup->lookupUserNames( [] ) ); + + $expect = []; + foreach ( $this->localUsers as $localUser ) { + $expect[$localUser->getName()] = $localUser->getId(); + } + $expect['UTDoesNotExist'] = 'X'; + ksort( $expect ); + + $expect2 = $expect; + $expect2[$this->localUsers[3]->getName()] = 'X'; + + $arg = array_fill_keys( array_keys( $expect ), 'X' ); + + $this->assertSame( $expect2, $lookup->lookupUserNames( $arg ) ); + $this->assertSame( $expect, $lookup->lookupUserNames( $arg, CentralIdLookup::AUDIENCE_RAW ) ); + $this->assertSame( $expect, $lookup->lookupUserNames( $arg, $user1 ) ); + $this->assertSame( $expect2, $lookup->lookupUserNames( $arg, $user2 ) ); + } + + public function testIsAttached() { + $lookup = new LocalIdLookup(); + $user1 = $this->getLookupUser(); + $user2 = User::newFromName( 'DoesNotExist' ); + + $this->assertTrue( $lookup->isAttached( $user1 ) ); + $this->assertFalse( $lookup->isAttached( $user2 ) ); + + $wiki = wfWikiID(); + $this->assertTrue( $lookup->isAttached( $user1, $wiki ) ); + $this->assertFalse( $lookup->isAttached( $user2, $wiki ) ); + + $wiki = 'not-' . wfWikiID(); + $this->assertFalse( $lookup->isAttached( $user1, $wiki ) ); + $this->assertFalse( $lookup->isAttached( $user2, $wiki ) ); + } + + /** + * @dataProvider provideIsAttachedShared + * @param bool $sharedDB $wgSharedDB is set + * @param bool $sharedTable $wgSharedTables contains 'user' + * @param bool $localDBSet $wgLocalDatabases contains the shared DB + */ + public function testIsAttachedShared( $sharedDB, $sharedTable, $localDBSet ) { + global $wgDBName; + $this->setMwGlobals( [ + 'wgSharedDB' => $sharedDB ? $wgDBName : null, + 'wgSharedTables' => $sharedTable ? [ 'user' ] : [], + 'wgLocalDatabases' => $localDBSet ? [ 'shared' ] : [], + ] ); + + $lookup = new LocalIdLookup(); + $this->assertSame( + $sharedDB && $sharedTable && $localDBSet, + $lookup->isAttached( $this->getLookupUser(), 'shared' ) + ); + } + + public static function provideIsAttachedShared() { + $ret = []; + for ( $i = 0; $i < 7; $i++ ) { + $ret[] = [ + (bool)( $i & 1 ), + (bool)( $i & 2 ), + (bool)( $i & 4 ), + ]; + } + return $ret; + } + +} diff --git a/www/wiki/tests/phpunit/includes/user/PasswordResetTest.php b/www/wiki/tests/phpunit/includes/user/PasswordResetTest.php new file mode 100644 index 00000000..1f578ab0 --- /dev/null +++ b/www/wiki/tests/phpunit/includes/user/PasswordResetTest.php @@ -0,0 +1,193 @@ +<?php + +use MediaWiki\Auth\AuthManager; + +/** + * @covers PasswordReset + * @group Database + */ +class PasswordResetTest extends MediaWikiTestCase { + /** + * @dataProvider provideIsAllowed + */ + public function testIsAllowed( $passwordResetRoutes, $enableEmail, + $allowsAuthenticationDataChange, $canEditPrivate, $block, $globalBlock, $isAllowed + ) { + $config = new HashConfig( [ + 'PasswordResetRoutes' => $passwordResetRoutes, + 'EnableEmail' => $enableEmail, + ] ); + + $authManager = $this->getMockBuilder( AuthManager::class )->disableOriginalConstructor() + ->getMock(); + $authManager->expects( $this->any() )->method( 'allowsAuthenticationDataChange' ) + ->willReturn( $allowsAuthenticationDataChange ? Status::newGood() : Status::newFatal( 'foo' ) ); + + $user = $this->getMockBuilder( User::class )->getMock(); + $user->expects( $this->any() )->method( 'getName' )->willReturn( 'Foo' ); + $user->expects( $this->any() )->method( 'getBlock' )->willReturn( $block ); + $user->expects( $this->any() )->method( 'getGlobalBlock' )->willReturn( $globalBlock ); + $user->expects( $this->any() )->method( 'isAllowed' ) + ->will( $this->returnCallback( function ( $perm ) use ( $canEditPrivate ) { + if ( $perm === 'editmyprivateinfo' ) { + return $canEditPrivate; + } else { + $this->fail( 'Unexpected permission check' ); + } + } ) ); + + $passwordReset = new PasswordReset( $config, $authManager ); + + $this->assertSame( $isAllowed, $passwordReset->isAllowed( $user )->isGood() ); + } + + public function provideIsAllowed() { + return [ + 'no routes' => [ + 'passwordResetRoutes' => [], + 'enableEmail' => true, + 'allowsAuthenticationDataChange' => true, + 'canEditPrivate' => true, + 'block' => null, + 'globalBlock' => null, + 'isAllowed' => false, + ], + 'email disabled' => [ + 'passwordResetRoutes' => [ 'username' => true ], + 'enableEmail' => false, + 'allowsAuthenticationDataChange' => true, + 'canEditPrivate' => true, + 'block' => null, + 'globalBlock' => null, + 'isAllowed' => false, + ], + 'auth data change disabled' => [ + 'passwordResetRoutes' => [ 'username' => true ], + 'enableEmail' => true, + 'allowsAuthenticationDataChange' => false, + 'canEditPrivate' => true, + 'block' => null, + 'globalBlock' => null, + 'isAllowed' => false, + ], + 'cannot edit private data' => [ + 'passwordResetRoutes' => [ 'username' => true ], + 'enableEmail' => true, + 'allowsAuthenticationDataChange' => true, + 'canEditPrivate' => false, + 'block' => null, + 'globalBlock' => null, + 'isAllowed' => false, + ], + 'blocked with account creation disabled' => [ + 'passwordResetRoutes' => [ 'username' => true ], + 'enableEmail' => true, + 'allowsAuthenticationDataChange' => true, + 'canEditPrivate' => true, + 'block' => new Block( [ 'createAccount' => true ] ), + 'globalBlock' => null, + 'isAllowed' => false, + ], + 'blocked w/o account creation disabled' => [ + 'passwordResetRoutes' => [ 'username' => true ], + 'enableEmail' => true, + 'allowsAuthenticationDataChange' => true, + 'canEditPrivate' => true, + 'block' => new Block( [] ), + 'globalBlock' => null, + 'isAllowed' => true, + ], + 'using blocked proxy' => [ + 'passwordResetRoutes' => [ 'username' => true ], + 'enableEmail' => true, + 'allowsAuthenticationDataChange' => true, + 'canEditPrivate' => true, + 'block' => new Block( [ 'systemBlock' => 'proxy' ] ), + 'globalBlock' => null, + 'isAllowed' => false, + ], + 'globally blocked with account creation disabled' => [ + 'passwordResetRoutes' => [ 'username' => true ], + 'enableEmail' => true, + 'allowsAuthenticationDataChange' => true, + 'canEditPrivate' => true, + 'block' => null, + 'globalBlock' => new Block( [ 'systemBlock' => 'global-block', 'createAccount' => true ] ), + 'isAllowed' => false, + ], + 'globally blocked with account creation not disabled' => [ + 'passwordResetRoutes' => [ 'username' => true ], + 'enableEmail' => true, + 'allowsAuthenticationDataChange' => true, + 'canEditPrivate' => true, + 'block' => null, + 'globalBlock' => new Block( [ 'systemBlock' => 'global-block', 'createAccount' => false ] ), + 'isAllowed' => true, + ], + 'blocked via wgSoftBlockRanges' => [ + 'passwordResetRoutes' => [ 'username' => true ], + 'enableEmail' => true, + 'allowsAuthenticationDataChange' => true, + 'canEditPrivate' => true, + 'block' => new Block( [ 'systemBlock' => 'wgSoftBlockRanges', 'anonOnly' => true ] ), + 'globalBlock' => null, + 'isAllowed' => true, + ], + 'all OK' => [ + 'passwordResetRoutes' => [ 'username' => true ], + 'enableEmail' => true, + 'allowsAuthenticationDataChange' => true, + 'canEditPrivate' => true, + 'block' => null, + 'globalBlock' => null, + 'isAllowed' => true, + ], + ]; + } + + public function testExecute_email() { + $config = new HashConfig( [ + 'PasswordResetRoutes' => [ 'username' => true, 'email' => true ], + 'EnableEmail' => true, + ] ); + + // Unregister the hooks for proper unit testing + $this->mergeMwGlobalArrayValue( 'wgHooks', [ + 'User::mailPasswordInternal' => [], + 'SpecialPasswordResetOnSubmit' => [], + ] ); + + $authManager = $this->getMockBuilder( AuthManager::class )->disableOriginalConstructor() + ->getMock(); + $authManager->expects( $this->any() )->method( 'allowsAuthenticationDataChange' ) + ->willReturn( Status::newGood() ); + $authManager->expects( $this->exactly( 2 ) )->method( 'changeAuthenticationData' ); + + $request = new FauxRequest(); + $request->setIP( '1.2.3.4' ); + $performingUser = $this->getMockBuilder( User::class )->getMock(); + $performingUser->expects( $this->any() )->method( 'getRequest' )->willReturn( $request ); + $performingUser->expects( $this->any() )->method( 'isAllowed' )->willReturn( true ); + + $targetUser1 = $this->getMockBuilder( User::class )->getMock(); + $targetUser2 = $this->getMockBuilder( User::class )->getMock(); + $targetUser1->expects( $this->any() )->method( 'getName' )->willReturn( 'User1' ); + $targetUser2->expects( $this->any() )->method( 'getName' )->willReturn( 'User2' ); + $targetUser1->expects( $this->any() )->method( 'getId' )->willReturn( 1 ); + $targetUser2->expects( $this->any() )->method( 'getId' )->willReturn( 2 ); + $targetUser1->expects( $this->any() )->method( 'getEmail' )->willReturn( 'foo@bar.baz' ); + $targetUser2->expects( $this->any() )->method( 'getEmail' )->willReturn( 'foo@bar.baz' ); + + $passwordReset = $this->getMockBuilder( PasswordReset::class ) + ->setMethods( [ 'getUsersByEmail' ] )->setConstructorArgs( [ $config, $authManager ] ) + ->getMock(); + $passwordReset->expects( $this->any() )->method( 'getUsersByEmail' )->with( 'foo@bar.baz' ) + ->willReturn( [ $targetUser1, $targetUser2 ] ); + + $status = $passwordReset->isAllowed( $performingUser ); + $this->assertTrue( $status->isGood() ); + + $status = $passwordReset->execute( $performingUser, null, 'foo@bar.baz' ); + $this->assertTrue( $status->isGood() ); + } +} diff --git a/www/wiki/tests/phpunit/includes/user/UserArrayFromResultTest.php b/www/wiki/tests/phpunit/includes/user/UserArrayFromResultTest.php new file mode 100644 index 00000000..beaacec8 --- /dev/null +++ b/www/wiki/tests/phpunit/includes/user/UserArrayFromResultTest.php @@ -0,0 +1,114 @@ +<?php + +/** + * @author Addshore + * @covers UserArrayFromResult + */ +class UserArrayFromResultTest extends MediaWikiTestCase { + + private function getMockResultWrapper( $row = null, $numRows = 1 ) { + $resultWrapper = $this->getMockBuilder( Wikimedia\Rdbms\ResultWrapper::class ) + ->disableOriginalConstructor(); + + $resultWrapper = $resultWrapper->getMock(); + $resultWrapper->expects( $this->atLeastOnce() ) + ->method( 'current' ) + ->will( $this->returnValue( $row ) ); + $resultWrapper->expects( $this->any() ) + ->method( 'numRows' ) + ->will( $this->returnValue( $numRows ) ); + + return $resultWrapper; + } + + private function getRowWithUsername( $username = 'fooUser' ) { + $row = new stdClass(); + $row->user_name = $username; + return $row; + } + + private function getUserArrayFromResult( $resultWrapper ) { + return new UserArrayFromResult( $resultWrapper ); + } + + /** + * @covers UserArrayFromResult::__construct + */ + public function testConstructionWithFalseRow() { + $row = false; + $resultWrapper = $this->getMockResultWrapper( $row ); + + $object = $this->getUserArrayFromResult( $resultWrapper ); + + $this->assertEquals( $resultWrapper, $object->res ); + $this->assertSame( 0, $object->key ); + $this->assertEquals( $row, $object->current ); + } + + /** + * @covers UserArrayFromResult::__construct + */ + public function testConstructionWithRow() { + $username = 'addshore'; + $row = $this->getRowWithUsername( $username ); + $resultWrapper = $this->getMockResultWrapper( $row ); + + $object = $this->getUserArrayFromResult( $resultWrapper ); + + $this->assertEquals( $resultWrapper, $object->res ); + $this->assertSame( 0, $object->key ); + $this->assertInstanceOf( User::class, $object->current ); + $this->assertEquals( $username, $object->current->mName ); + } + + public static function provideNumberOfRows() { + return [ + [ 0 ], + [ 1 ], + [ 122 ], + ]; + } + + /** + * @dataProvider provideNumberOfRows + * @covers UserArrayFromResult::count + */ + public function testCountWithVaryingValues( $numRows ) { + $object = $this->getUserArrayFromResult( $this->getMockResultWrapper( + $this->getRowWithUsername(), + $numRows + ) ); + $this->assertEquals( $numRows, $object->count() ); + } + + /** + * @covers UserArrayFromResult::current + */ + public function testCurrentAfterConstruction() { + $username = 'addshore'; + $userRow = $this->getRowWithUsername( $username ); + $object = $this->getUserArrayFromResult( $this->getMockResultWrapper( $userRow ) ); + $this->assertInstanceOf( User::class, $object->current() ); + $this->assertEquals( $username, $object->current()->mName ); + } + + public function provideTestValid() { + return [ + [ $this->getRowWithUsername(), true ], + [ false, false ], + ]; + } + + /** + * @dataProvider provideTestValid + * @covers UserArrayFromResult::valid + */ + public function testValid( $input, $expected ) { + $object = $this->getUserArrayFromResult( $this->getMockResultWrapper( $input ) ); + $this->assertEquals( $expected, $object->valid() ); + } + + // @todo unit test for key() + // @todo unit test for next() + // @todo unit test for rewind() +} diff --git a/www/wiki/tests/phpunit/includes/user/UserGroupMembershipTest.php b/www/wiki/tests/phpunit/includes/user/UserGroupMembershipTest.php new file mode 100644 index 00000000..4862747b --- /dev/null +++ b/www/wiki/tests/phpunit/includes/user/UserGroupMembershipTest.php @@ -0,0 +1,153 @@ +<?php + +/** + * @group Database + */ +class UserGroupMembershipTest extends MediaWikiTestCase { + + protected $tablesUsed = [ 'user', 'user_groups' ]; + + /** + * @var User Belongs to no groups + */ + protected $userNoGroups; + /** + * @var User Belongs to the 'unittesters' group indefinitely, and the + * 'testwriters' group with expiry + */ + protected $userTester; + /** + * @var string The timestamp, in TS_MW format, of the expiry of $userTester's + * membership in the 'testwriters' group + */ + protected $expiryTime; + + protected function setUp() { + parent::setUp(); + + $this->setMwGlobals( [ + 'wgGroupPermissions' => [ + 'unittesters' => [ + 'runtest' => true, + ], + 'testwriters' => [ + 'writetest' => true, + ] + ] + ] ); + + $this->userNoGroups = new User; + $this->userNoGroups->setName( 'NoGroups' ); + $this->userNoGroups->addToDatabase(); + + $this->userTester = new User; + $this->userTester->setName( 'Tester' ); + $this->userTester->addToDatabase(); + $this->userTester->addGroup( 'unittesters' ); + $this->expiryTime = wfTimestamp( TS_MW, time() + 100500 ); + $this->userTester->addGroup( 'testwriters', $this->expiryTime ); + } + + /** + * @covers UserGroupMembership::insert + * @covers UserGroupMembership::delete + */ + public function testAddAndRemoveGroups() { + $user = $this->getMutableTestUser()->getUser(); + + // basic tests + $ugm = new UserGroupMembership( $user->getId(), 'unittesters' ); + $this->assertTrue( $ugm->insert() ); + $user->clearInstanceCache(); + $this->assertContains( 'unittesters', $user->getGroups() ); + $this->assertArrayHasKey( 'unittesters', $user->getGroupMemberships() ); + $this->assertTrue( $user->isAllowed( 'runtest' ) ); + + // try updating without allowUpdate. Should fail + $ugm = new UserGroupMembership( $user->getId(), 'unittesters', $this->expiryTime ); + $this->assertFalse( $ugm->insert() ); + + // now try updating with allowUpdate + $this->assertTrue( $ugm->insert( 2 ) ); + $user->clearInstanceCache(); + $this->assertContains( 'unittesters', $user->getGroups() ); + $this->assertArrayHasKey( 'unittesters', $user->getGroupMemberships() ); + $this->assertTrue( $user->isAllowed( 'runtest' ) ); + + // try removing the group + $ugm->delete(); + $user->clearInstanceCache(); + $this->assertThat( $user->getGroups(), + $this->logicalNot( $this->contains( 'unittesters' ) ) ); + $this->assertThat( $user->getGroupMemberships(), + $this->logicalNot( $this->arrayHasKey( 'unittesters' ) ) ); + $this->assertFalse( $user->isAllowed( 'runtest' ) ); + + // check that the user group is now in user_former_groups + $this->assertContains( 'unittesters', $user->getFormerGroups() ); + } + + private function addUserTesterToExpiredGroup() { + // put $userTester in a group with expiry in the past + $ugm = new UserGroupMembership( $this->userTester->getId(), 'sysop', '20010102030405' ); + $ugm->insert(); + } + + /** + * @covers UserGroupMembership::getMembershipsForUser + */ + public function testGetMembershipsForUser() { + $this->addUserTesterToExpiredGroup(); + + // check that the user in no groups has no group memberships + $ugms = UserGroupMembership::getMembershipsForUser( $this->userNoGroups->getId() ); + $this->assertEmpty( $ugms ); + + // check that the user in 2 groups has 2 group memberships + $testerUserId = $this->userTester->getId(); + $ugms = UserGroupMembership::getMembershipsForUser( $testerUserId ); + $this->assertCount( 2, $ugms ); + + // check that the required group memberships are present on $userTester, + // with the correct user IDs and expiries + $expectedGroups = [ 'unittesters', 'testwriters' ]; + + foreach ( $expectedGroups as $group ) { + $this->assertArrayHasKey( $group, $ugms ); + $this->assertEquals( $ugms[$group]->getUserId(), $testerUserId ); + $this->assertEquals( $ugms[$group]->getGroup(), $group ); + + if ( $group === 'unittesters' ) { + $this->assertNull( $ugms[$group]->getExpiry() ); + } elseif ( $group === 'testwriters' ) { + $this->assertEquals( $ugms[$group]->getExpiry(), $this->expiryTime ); + } + } + } + + /** + * @covers UserGroupMembership::getMembership + */ + public function testGetMembership() { + $this->addUserTesterToExpiredGroup(); + + // groups that the user doesn't belong to shouldn't be returned + $ugm = UserGroupMembership::getMembership( $this->userNoGroups->getId(), 'sysop' ); + $this->assertFalse( $ugm ); + + // implicit groups shouldn't be returned + $ugm = UserGroupMembership::getMembership( $this->userNoGroups->getId(), 'user' ); + $this->assertFalse( $ugm ); + + // expired groups shouldn't be returned + $ugm = UserGroupMembership::getMembership( $this->userTester->getId(), 'sysop' ); + $this->assertFalse( $ugm ); + + // groups that the user does belong to should be returned with correct properties + $ugm = UserGroupMembership::getMembership( $this->userTester->getId(), 'unittesters' ); + $this->assertInstanceOf( UserGroupMembership::class, $ugm ); + $this->assertEquals( $ugm->getUserId(), $this->userTester->getId() ); + $this->assertEquals( $ugm->getGroup(), 'unittesters' ); + $this->assertNull( $ugm->getExpiry() ); + } +} diff --git a/www/wiki/tests/phpunit/includes/user/UserTest.php b/www/wiki/tests/phpunit/includes/user/UserTest.php new file mode 100644 index 00000000..ebfecbca --- /dev/null +++ b/www/wiki/tests/phpunit/includes/user/UserTest.php @@ -0,0 +1,1208 @@ +<?php + +define( 'NS_UNITTEST', 5600 ); +define( 'NS_UNITTEST_TALK', 5601 ); + +use MediaWiki\MediaWikiServices; +use Wikimedia\TestingAccessWrapper; + +/** + * @group Database + */ +class UserTest extends MediaWikiTestCase { + /** + * @var User + */ + protected $user; + + protected function setUp() { + parent::setUp(); + + $this->setMwGlobals( [ + 'wgGroupPermissions' => [], + 'wgRevokePermissions' => [], + 'wgActorTableSchemaMigrationStage' => MIGRATION_WRITE_BOTH, + ] ); + $this->overrideMwServices(); + + $this->setUpPermissionGlobals(); + + $this->user = $this->getTestUser( [ 'unittesters' ] )->getUser(); + } + + private function setUpPermissionGlobals() { + global $wgGroupPermissions, $wgRevokePermissions; + + # Data for regular $wgGroupPermissions test + $wgGroupPermissions['unittesters'] = [ + 'test' => true, + 'runtest' => true, + 'writetest' => false, + 'nukeworld' => false, + ]; + $wgGroupPermissions['testwriters'] = [ + 'test' => true, + 'writetest' => true, + 'modifytest' => true, + ]; + + # Data for regular $wgRevokePermissions test + $wgRevokePermissions['formertesters'] = [ + 'runtest' => true, + ]; + + # For the options test + $wgGroupPermissions['*'] = [ + 'editmyoptions' => true, + ]; + } + + /** + * @covers User::getGroupPermissions + */ + public function testGroupPermissions() { + $rights = User::getGroupPermissions( [ 'unittesters' ] ); + $this->assertContains( 'runtest', $rights ); + $this->assertNotContains( 'writetest', $rights ); + $this->assertNotContains( 'modifytest', $rights ); + $this->assertNotContains( 'nukeworld', $rights ); + + $rights = User::getGroupPermissions( [ 'unittesters', 'testwriters' ] ); + $this->assertContains( 'runtest', $rights ); + $this->assertContains( 'writetest', $rights ); + $this->assertContains( 'modifytest', $rights ); + $this->assertNotContains( 'nukeworld', $rights ); + } + + /** + * @covers User::getGroupPermissions + */ + public function testRevokePermissions() { + $rights = User::getGroupPermissions( [ 'unittesters', 'formertesters' ] ); + $this->assertNotContains( 'runtest', $rights ); + $this->assertNotContains( 'writetest', $rights ); + $this->assertNotContains( 'modifytest', $rights ); + $this->assertNotContains( 'nukeworld', $rights ); + } + + /** + * @covers User::getRights + */ + public function testUserPermissions() { + $rights = $this->user->getRights(); + $this->assertContains( 'runtest', $rights ); + $this->assertNotContains( 'writetest', $rights ); + $this->assertNotContains( 'modifytest', $rights ); + $this->assertNotContains( 'nukeworld', $rights ); + } + + /** + * @covers User::getRights + */ + public function testUserGetRightsHooks() { + $user = $this->getTestUser( [ 'unittesters', 'testwriters' ] )->getUser(); + $userWrapper = TestingAccessWrapper::newFromObject( $user ); + + $rights = $user->getRights(); + $this->assertContains( 'test', $rights, 'sanity check' ); + $this->assertContains( 'runtest', $rights, 'sanity check' ); + $this->assertContains( 'writetest', $rights, 'sanity check' ); + $this->assertNotContains( 'nukeworld', $rights, 'sanity check' ); + + // Add a hook manipluating the rights + $this->mergeMwGlobalArrayValue( 'wgHooks', [ 'UserGetRights' => [ function ( $user, &$rights ) { + $rights[] = 'nukeworld'; + $rights = array_diff( $rights, [ 'writetest' ] ); + } ] ] ); + + $userWrapper->mRights = null; + $rights = $user->getRights(); + $this->assertContains( 'test', $rights ); + $this->assertContains( 'runtest', $rights ); + $this->assertNotContains( 'writetest', $rights ); + $this->assertContains( 'nukeworld', $rights ); + + // Add a Session that limits rights + $mock = $this->getMockBuilder( stdClass::class ) + ->setMethods( [ 'getAllowedUserRights', 'deregisterSession', 'getSessionId' ] ) + ->getMock(); + $mock->method( 'getAllowedUserRights' )->willReturn( [ 'test', 'writetest' ] ); + $mock->method( 'getSessionId' )->willReturn( + new MediaWiki\Session\SessionId( str_repeat( 'X', 32 ) ) + ); + $session = MediaWiki\Session\TestUtils::getDummySession( $mock ); + $mockRequest = $this->getMockBuilder( FauxRequest::class ) + ->setMethods( [ 'getSession' ] ) + ->getMock(); + $mockRequest->method( 'getSession' )->willReturn( $session ); + $userWrapper->mRequest = $mockRequest; + + $userWrapper->mRights = null; + $rights = $user->getRights(); + $this->assertContains( 'test', $rights ); + $this->assertNotContains( 'runtest', $rights ); + $this->assertNotContains( 'writetest', $rights ); + $this->assertNotContains( 'nukeworld', $rights ); + } + + /** + * @dataProvider provideGetGroupsWithPermission + * @covers User::getGroupsWithPermission + */ + public function testGetGroupsWithPermission( $expected, $right ) { + $result = User::getGroupsWithPermission( $right ); + sort( $result ); + sort( $expected ); + + $this->assertEquals( $expected, $result, "Groups with permission $right" ); + } + + public static function provideGetGroupsWithPermission() { + return [ + [ + [ 'unittesters', 'testwriters' ], + 'test' + ], + [ + [ 'unittesters' ], + 'runtest' + ], + [ + [ 'testwriters' ], + 'writetest' + ], + [ + [ 'testwriters' ], + 'modifytest' + ], + ]; + } + + /** + * @dataProvider provideIPs + * @covers User::isIP + */ + public function testIsIP( $value, $result, $message ) { + $this->assertEquals( $this->user->isIP( $value ), $result, $message ); + } + + public static function provideIPs() { + return [ + [ '', false, 'Empty string' ], + [ ' ', false, 'Blank space' ], + [ '10.0.0.0', true, 'IPv4 private 10/8' ], + [ '10.255.255.255', true, 'IPv4 private 10/8' ], + [ '192.168.1.1', true, 'IPv4 private 192.168/16' ], + [ '203.0.113.0', true, 'IPv4 example' ], + [ '2002:ffff:ffff:ffff:ffff:ffff:ffff:ffff', true, 'IPv6 example' ], + // Not valid IPs but classified as such by MediaWiki for negated asserting + // of whether this might be the identifier of a logged-out user or whether + // to allow usernames like it. + [ '300.300.300.300', true, 'Looks too much like an IPv4 address' ], + [ '203.0.113.xxx', true, 'Assigned by UseMod to cloaked logged-out users' ], + ]; + } + + /** + * @dataProvider provideUserNames + * @covers User::isValidUserName + */ + public function testIsValidUserName( $username, $result, $message ) { + $this->assertEquals( $this->user->isValidUserName( $username ), $result, $message ); + } + + public static function provideUserNames() { + return [ + [ '', false, 'Empty string' ], + [ ' ', false, 'Blank space' ], + [ 'abcd', false, 'Starts with small letter' ], + [ 'Ab/cd', false, 'Contains slash' ], + [ 'Ab cd', true, 'Whitespace' ], + [ '192.168.1.1', false, 'IP' ], + [ '116.17.184.5/32', false, 'IP range' ], + [ '::e:f:2001/96', false, 'IPv6 range' ], + [ 'User:Abcd', false, 'Reserved Namespace' ], + [ '12abcd232', true, 'Starts with Numbers' ], + [ '?abcd', true, 'Start with ? mark' ], + [ '#abcd', false, 'Start with #' ], + [ 'Abcdകഖഗഘ', true, ' Mixed scripts' ], + [ 'ജോസ്തോമസ്', false, 'ZWNJ- Format control character' ], + [ 'Ab cd', false, ' Ideographic space' ], + [ '300.300.300.300', false, 'Looks too much like an IPv4 address' ], + [ '302.113.311.900', false, 'Looks too much like an IPv4 address' ], + [ '203.0.113.xxx', false, 'Reserved for usage by UseMod for cloaked logged-out users' ], + ]; + } + + /** + * Test, if for all rights a right- message exist, + * which is used on Special:ListGroupRights as help text + * Extensions and core + * + * @coversNothing + */ + public function testAllRightsWithMessage() { + // Getting all user rights, for core: User::$mCoreRights, for extensions: $wgAvailableRights + $allRights = User::getAllRights(); + $allMessageKeys = Language::getMessageKeysFor( 'en' ); + + $rightsWithMessage = []; + foreach ( $allMessageKeys as $message ) { + // === 0: must be at beginning of string (position 0) + if ( strpos( $message, 'right-' ) === 0 ) { + $rightsWithMessage[] = substr( $message, strlen( 'right-' ) ); + } + } + + sort( $allRights ); + sort( $rightsWithMessage ); + + $this->assertEquals( + $allRights, + $rightsWithMessage, + 'Each user rights (core/extensions) has a corresponding right- message.' + ); + } + + /** + * Test User::editCount + * @group medium + * @covers User::getEditCount + */ + public function testGetEditCount() { + $user = $this->getMutableTestUser()->getUser(); + + // let the user have a few (3) edits + $page = WikiPage::factory( Title::newFromText( 'Help:UserTest_EditCount' ) ); + for ( $i = 0; $i < 3; $i++ ) { + $page->doEditContent( + ContentHandler::makeContent( (string)$i, $page->getTitle() ), + 'test', + 0, + false, + $user + ); + } + + $this->assertEquals( + 3, + $user->getEditCount(), + 'After three edits, the user edit count should be 3' + ); + + // increase the edit count + $user->incEditCount(); + + $this->assertEquals( + 4, + $user->getEditCount(), + 'After increasing the edit count manually, the user edit count should be 4' + ); + } + + /** + * Test User::editCount + * @group medium + * @covers User::getEditCount + */ + public function testGetEditCountForAnons() { + $user = User::newFromName( 'Anonymous' ); + + $this->assertNull( + $user->getEditCount(), + 'Edit count starts null for anonymous users.' + ); + + $user->incEditCount(); + + $this->assertNull( + $user->getEditCount(), + 'Edit count remains null for anonymous users despite calls to increase it.' + ); + } + + /** + * Test User::editCount + * @group medium + * @covers User::incEditCount + */ + public function testIncEditCount() { + $user = $this->getMutableTestUser()->getUser(); + $user->incEditCount(); + + $reloadedUser = User::newFromId( $user->getId() ); + $reloadedUser->incEditCount(); + + $this->assertEquals( + 2, + $reloadedUser->getEditCount(), + 'Increasing the edit count after a fresh load leaves the object up to date.' + ); + } + + /** + * Test changing user options. + * @covers User::setOption + * @covers User::getOption + */ + public function testOptions() { + $user = $this->getMutableTestUser()->getUser(); + + $user->setOption( 'userjs-someoption', 'test' ); + $user->setOption( 'rclimit', 200 ); + $user->setOption( 'wpwatchlistdays', '0' ); + $user->saveSettings(); + + $user = User::newFromName( $user->getName() ); + $user->load( User::READ_LATEST ); + $this->assertEquals( 'test', $user->getOption( 'userjs-someoption' ) ); + $this->assertEquals( 200, $user->getOption( 'rclimit' ) ); + + $user = User::newFromName( $user->getName() ); + MediaWikiServices::getInstance()->getMainWANObjectCache()->clearProcessCache(); + $this->assertEquals( 'test', $user->getOption( 'userjs-someoption' ) ); + $this->assertEquals( 200, $user->getOption( 'rclimit' ) ); + + // Check that an option saved as a string '0' is returned as an integer. + $user = User::newFromName( $user->getName() ); + $user->load( User::READ_LATEST ); + $this->assertSame( 0, $user->getOption( 'wpwatchlistdays' ) ); + } + + /** + * T39963 + * Make sure defaults are loaded when setOption is called. + * @covers User::loadOptions + */ + public function testAnonOptions() { + global $wgDefaultUserOptions; + $this->user->setOption( 'userjs-someoption', 'test' ); + $this->assertEquals( $wgDefaultUserOptions['rclimit'], $this->user->getOption( 'rclimit' ) ); + $this->assertEquals( 'test', $this->user->getOption( 'userjs-someoption' ) ); + } + + /** + * Test password validity checks. There are 3 checks in core, + * - ensure the password meets the minimal length + * - ensure the password is not the same as the username + * - ensure the username/password combo isn't forbidden + * @covers User::checkPasswordValidity() + * @covers User::getPasswordValidity() + * @covers User::isValidPassword() + */ + public function testCheckPasswordValidity() { + $this->setMwGlobals( [ + 'wgPasswordPolicy' => [ + 'policies' => [ + 'sysop' => [ + 'MinimalPasswordLength' => 8, + 'MinimumPasswordLengthToLogin' => 1, + 'PasswordCannotMatchUsername' => 1, + ], + 'default' => [ + 'MinimalPasswordLength' => 6, + 'PasswordCannotMatchUsername' => true, + 'PasswordCannotMatchBlacklist' => true, + 'MaximalPasswordLength' => 40, + ], + ], + 'checks' => [ + 'MinimalPasswordLength' => 'PasswordPolicyChecks::checkMinimalPasswordLength', + 'MinimumPasswordLengthToLogin' => 'PasswordPolicyChecks::checkMinimumPasswordLengthToLogin', + 'PasswordCannotMatchUsername' => 'PasswordPolicyChecks::checkPasswordCannotMatchUsername', + 'PasswordCannotMatchBlacklist' => 'PasswordPolicyChecks::checkPasswordCannotMatchBlacklist', + 'MaximalPasswordLength' => 'PasswordPolicyChecks::checkMaximalPasswordLength', + ], + ], + ] ); + + $user = static::getTestUser()->getUser(); + + // Sanity + $this->assertTrue( $user->isValidPassword( 'Password1234' ) ); + + // Minimum length + $this->assertFalse( $user->isValidPassword( 'a' ) ); + $this->assertFalse( $user->checkPasswordValidity( 'a' )->isGood() ); + $this->assertTrue( $user->checkPasswordValidity( 'a' )->isOK() ); + $this->assertEquals( 'passwordtooshort', $user->getPasswordValidity( 'a' ) ); + + // Maximum length + $longPass = str_repeat( 'a', 41 ); + $this->assertFalse( $user->isValidPassword( $longPass ) ); + $this->assertFalse( $user->checkPasswordValidity( $longPass )->isGood() ); + $this->assertFalse( $user->checkPasswordValidity( $longPass )->isOK() ); + $this->assertEquals( 'passwordtoolong', $user->getPasswordValidity( $longPass ) ); + + // Matches username + $this->assertFalse( $user->checkPasswordValidity( $user->getName() )->isGood() ); + $this->assertTrue( $user->checkPasswordValidity( $user->getName() )->isOK() ); + $this->assertEquals( 'password-name-match', $user->getPasswordValidity( $user->getName() ) ); + + // On the forbidden list + $user = User::newFromName( 'Useruser' ); + $this->assertFalse( $user->checkPasswordValidity( 'Passpass' )->isGood() ); + $this->assertEquals( 'password-login-forbidden', $user->getPasswordValidity( 'Passpass' ) ); + } + + /** + * @covers User::getCanonicalName() + * @dataProvider provideGetCanonicalName + */ + public function testGetCanonicalName( $name, $expectedArray ) { + // fake interwiki map for the 'Interwiki prefix' testcase + $this->mergeMwGlobalArrayValue( 'wgHooks', [ + 'InterwikiLoadPrefix' => [ + function ( $prefix, &$iwdata ) { + if ( $prefix === 'interwiki' ) { + $iwdata = [ + 'iw_url' => 'http://example.com/', + 'iw_local' => 0, + 'iw_trans' => 0, + ]; + return false; + } + }, + ], + ] ); + + foreach ( $expectedArray as $validate => $expected ) { + $this->assertEquals( + $expected, + User::getCanonicalName( $name, $validate === 'false' ? false : $validate ), $validate ); + } + } + + public static function provideGetCanonicalName() { + return [ + 'Leading space' => [ ' Leading space', [ 'creatable' => 'Leading space' ] ], + 'Trailing space ' => [ 'Trailing space ', [ 'creatable' => 'Trailing space' ] ], + 'Namespace prefix' => [ 'Talk:Username', [ 'creatable' => false, 'usable' => false, + 'valid' => false, 'false' => 'Talk:Username' ] ], + 'Interwiki prefix' => [ 'interwiki:Username', [ 'creatable' => false, 'usable' => false, + 'valid' => false, 'false' => 'Interwiki:Username' ] ], + 'With hash' => [ 'name with # hash', [ 'creatable' => false, 'usable' => false ] ], + 'Multi spaces' => [ 'Multi spaces', [ 'creatable' => 'Multi spaces', + 'usable' => 'Multi spaces' ] ], + 'Lowercase' => [ 'lowercase', [ 'creatable' => 'Lowercase' ] ], + 'Invalid character' => [ 'in[]valid', [ 'creatable' => false, 'usable' => false, + 'valid' => false, 'false' => 'In[]valid' ] ], + 'With slash' => [ 'with / slash', [ 'creatable' => false, 'usable' => false, 'valid' => false, + 'false' => 'With / slash' ] ], + ]; + } + + /** + * @covers User::equals + */ + public function testEquals() { + $first = $this->getMutableTestUser()->getUser(); + $second = User::newFromName( $first->getName() ); + + $this->assertTrue( $first->equals( $first ) ); + $this->assertTrue( $first->equals( $second ) ); + $this->assertTrue( $second->equals( $first ) ); + + $third = $this->getMutableTestUser()->getUser(); + $fourth = $this->getMutableTestUser()->getUser(); + + $this->assertFalse( $third->equals( $fourth ) ); + $this->assertFalse( $fourth->equals( $third ) ); + + // Test users loaded from db with id + $user = $this->getMutableTestUser()->getUser(); + $fifth = User::newFromId( $user->getId() ); + $sixth = User::newFromName( $user->getName() ); + $this->assertTrue( $fifth->equals( $sixth ) ); + } + + /** + * @covers User::getId + */ + public function testGetId() { + $user = static::getTestUser()->getUser(); + $this->assertTrue( $user->getId() > 0 ); + } + + /** + * @covers User::isLoggedIn + * @covers User::isAnon + */ + public function testLoggedIn() { + $user = $this->getMutableTestUser()->getUser(); + $this->assertTrue( $user->isLoggedIn() ); + $this->assertFalse( $user->isAnon() ); + + // Non-existent users are perceived as anonymous + $user = User::newFromName( 'UTNonexistent' ); + $this->assertFalse( $user->isLoggedIn() ); + $this->assertTrue( $user->isAnon() ); + + $user = new User; + $this->assertFalse( $user->isLoggedIn() ); + $this->assertTrue( $user->isAnon() ); + } + + /** + * @covers User::checkAndSetTouched + */ + public function testCheckAndSetTouched() { + $user = $this->getMutableTestUser()->getUser(); + $user = TestingAccessWrapper::newFromObject( $user ); + $this->assertTrue( $user->isLoggedIn() ); + + $touched = $user->getDBTouched(); + $this->assertTrue( + $user->checkAndSetTouched(), "checkAndSetTouched() succeded" ); + $this->assertGreaterThan( + $touched, $user->getDBTouched(), "user_touched increased with casOnTouched()" ); + + $touched = $user->getDBTouched(); + $this->assertTrue( + $user->checkAndSetTouched(), "checkAndSetTouched() succeded #2" ); + $this->assertGreaterThan( + $touched, $user->getDBTouched(), "user_touched increased with casOnTouched() #2" ); + } + + /** + * @covers User::findUsersByGroup + */ + public function testFindUsersByGroup() { + $users = User::findUsersByGroup( [] ); + $this->assertEquals( 0, iterator_count( $users ) ); + + $users = User::findUsersByGroup( 'foo' ); + $this->assertEquals( 0, iterator_count( $users ) ); + + $user = $this->getMutableTestUser( [ 'foo' ] )->getUser(); + $users = User::findUsersByGroup( 'foo' ); + $this->assertEquals( 1, iterator_count( $users ) ); + $users->rewind(); + $this->assertTrue( $user->equals( $users->current() ) ); + + // arguments have OR relationship + $user2 = $this->getMutableTestUser( [ 'bar' ] )->getUser(); + $users = User::findUsersByGroup( [ 'foo', 'bar' ] ); + $this->assertEquals( 2, iterator_count( $users ) ); + $users->rewind(); + $this->assertTrue( $user->equals( $users->current() ) ); + $users->next(); + $this->assertTrue( $user2->equals( $users->current() ) ); + + // users are not duplicated + $user = $this->getMutableTestUser( [ 'baz', 'boom' ] )->getUser(); + $users = User::findUsersByGroup( [ 'baz', 'boom' ] ); + $this->assertEquals( 1, iterator_count( $users ) ); + $users->rewind(); + $this->assertTrue( $user->equals( $users->current() ) ); + } + + /** + * When a user is autoblocked a cookie is set with which to track them + * in case they log out and change IP addresses. + * @link https://phabricator.wikimedia.org/T5233 + */ + public function testAutoblockCookies() { + // Set up the bits of global configuration that we use. + $this->setMwGlobals( [ + 'wgCookieSetOnAutoblock' => true, + 'wgCookiePrefix' => 'wmsitetitle', + 'wgSecretKey' => MWCryptRand::generateHex( 64, true ), + ] ); + + // Unregister the hooks for proper unit testing + $this->mergeMwGlobalArrayValue( 'wgHooks', [ + 'PerformRetroactiveAutoblock' => [] + ] ); + + // 1. Log in a test user, and block them. + $userBlocker = $this->getTestSysop()->getUser(); + $user1tmp = $this->getTestUser()->getUser(); + $request1 = new FauxRequest(); + $request1->getSession()->setUser( $user1tmp ); + $expiryFiveHours = wfTimestamp() + ( 5 * 60 * 60 ); + $block = new Block( [ + 'enableAutoblock' => true, + 'expiry' => wfTimestamp( TS_MW, $expiryFiveHours ), + ] ); + $block->setBlocker( $this->getTestSysop()->getUser() ); + $block->setTarget( $user1tmp ); + $block->setBlocker( $userBlocker ); + $res = $block->insert(); + $this->assertTrue( (bool)$res['id'], 'Failed to insert block' ); + $user1 = User::newFromSession( $request1 ); + $user1->mBlock = $block; + $user1->load(); + + // Confirm that the block has been applied as required. + $this->assertTrue( $user1->isLoggedIn() ); + $this->assertTrue( $user1->isBlocked() ); + $this->assertEquals( Block::TYPE_USER, $block->getType() ); + $this->assertTrue( $block->isAutoblocking() ); + $this->assertGreaterThanOrEqual( 1, $block->getId() ); + + // Test for the desired cookie name, value, and expiry. + $cookies = $request1->response()->getCookies(); + $this->assertArrayHasKey( 'wmsitetitleBlockID', $cookies ); + $this->assertEquals( $expiryFiveHours, $cookies['wmsitetitleBlockID']['expire'] ); + $cookieValue = Block::getIdFromCookieValue( $cookies['wmsitetitleBlockID']['value'] ); + $this->assertEquals( $block->getId(), $cookieValue ); + + // 2. Create a new request, set the cookies, and see if the (anon) user is blocked. + $request2 = new FauxRequest(); + $request2->setCookie( 'BlockID', $block->getCookieValue() ); + $user2 = User::newFromSession( $request2 ); + $user2->load(); + $this->assertNotEquals( $user1->getId(), $user2->getId() ); + $this->assertNotEquals( $user1->getToken(), $user2->getToken() ); + $this->assertTrue( $user2->isAnon() ); + $this->assertFalse( $user2->isLoggedIn() ); + $this->assertTrue( $user2->isBlocked() ); + // Non-strict type-check. + $this->assertEquals( true, $user2->getBlock()->isAutoblocking(), 'Autoblock does not work' ); + // Can't directly compare the objects becuase of member type differences. + // One day this will work: $this->assertEquals( $block, $user2->getBlock() ); + $this->assertEquals( $block->getId(), $user2->getBlock()->getId() ); + $this->assertEquals( $block->getExpiry(), $user2->getBlock()->getExpiry() ); + + // 3. Finally, set up a request as a new user, and the block should still be applied. + $user3tmp = $this->getTestUser()->getUser(); + $request3 = new FauxRequest(); + $request3->getSession()->setUser( $user3tmp ); + $request3->setCookie( 'BlockID', $block->getId() ); + $user3 = User::newFromSession( $request3 ); + $user3->load(); + $this->assertTrue( $user3->isLoggedIn() ); + $this->assertTrue( $user3->isBlocked() ); + $this->assertEquals( true, $user3->getBlock()->isAutoblocking() ); // Non-strict type-check. + + // Clean up. + $block->delete(); + } + + /** + * Make sure that no cookie is set to track autoblocked users + * when $wgCookieSetOnAutoblock is false. + */ + public function testAutoblockCookiesDisabled() { + // Set up the bits of global configuration that we use. + $this->setMwGlobals( [ + 'wgCookieSetOnAutoblock' => false, + 'wgCookiePrefix' => 'wm_no_cookies', + 'wgSecretKey' => MWCryptRand::generateHex( 64, true ), + ] ); + + // Unregister the hooks for proper unit testing + $this->mergeMwGlobalArrayValue( 'wgHooks', [ + 'PerformRetroactiveAutoblock' => [] + ] ); + + // 1. Log in a test user, and block them. + $userBlocker = $this->getTestSysop()->getUser(); + $testUser = $this->getTestUser()->getUser(); + $request1 = new FauxRequest(); + $request1->getSession()->setUser( $testUser ); + $block = new Block( [ 'enableAutoblock' => true ] ); + $block->setBlocker( $this->getTestSysop()->getUser() ); + $block->setTarget( $testUser ); + $block->setBlocker( $userBlocker ); + $res = $block->insert(); + $this->assertTrue( (bool)$res['id'], 'Failed to insert block' ); + $user = User::newFromSession( $request1 ); + $user->mBlock = $block; + $user->load(); + + // 2. Test that the cookie IS NOT present. + $this->assertTrue( $user->isLoggedIn() ); + $this->assertTrue( $user->isBlocked() ); + $this->assertEquals( Block::TYPE_USER, $block->getType() ); + $this->assertTrue( $block->isAutoblocking() ); + $this->assertGreaterThanOrEqual( 1, $user->getBlockId() ); + $this->assertGreaterThanOrEqual( $block->getId(), $user->getBlockId() ); + $cookies = $request1->response()->getCookies(); + $this->assertArrayNotHasKey( 'wm_no_cookiesBlockID', $cookies ); + + // Clean up. + $block->delete(); + } + + /** + * When a user is autoblocked and a cookie is set to track them, the expiry time of the cookie + * should match the block's expiry, to a maximum of 24 hours. If the expiry time is changed, + * the cookie's should change with it. + */ + public function testAutoblockCookieInfiniteExpiry() { + $this->setMwGlobals( [ + 'wgCookieSetOnAutoblock' => true, + 'wgCookiePrefix' => 'wm_infinite_block', + 'wgSecretKey' => MWCryptRand::generateHex( 64, true ), + ] ); + + // Unregister the hooks for proper unit testing + $this->mergeMwGlobalArrayValue( 'wgHooks', [ + 'PerformRetroactiveAutoblock' => [] + ] ); + + // 1. Log in a test user, and block them indefinitely. + $userBlocker = $this->getTestSysop()->getUser(); + $user1Tmp = $this->getTestUser()->getUser(); + $request1 = new FauxRequest(); + $request1->getSession()->setUser( $user1Tmp ); + $block = new Block( [ 'enableAutoblock' => true, 'expiry' => 'infinity' ] ); + $block->setBlocker( $this->getTestSysop()->getUser() ); + $block->setTarget( $user1Tmp ); + $block->setBlocker( $userBlocker ); + $res = $block->insert(); + $this->assertTrue( (bool)$res['id'], 'Failed to insert block' ); + $user1 = User::newFromSession( $request1 ); + $user1->mBlock = $block; + $user1->load(); + + // 2. Test the cookie's expiry timestamp. + $this->assertTrue( $user1->isLoggedIn() ); + $this->assertTrue( $user1->isBlocked() ); + $this->assertEquals( Block::TYPE_USER, $block->getType() ); + $this->assertTrue( $block->isAutoblocking() ); + $this->assertGreaterThanOrEqual( 1, $user1->getBlockId() ); + $cookies = $request1->response()->getCookies(); + // Test the cookie's expiry to the nearest minute. + $this->assertArrayHasKey( 'wm_infinite_blockBlockID', $cookies ); + $expOneDay = wfTimestamp() + ( 24 * 60 * 60 ); + // Check for expiry dates in a 10-second window, to account for slow testing. + $this->assertEquals( + $expOneDay, + $cookies['wm_infinite_blockBlockID']['expire'], + 'Expiry date', + 5.0 + ); + + // 3. Change the block's expiry (to 2 hours), and the cookie's should be changed also. + $newExpiry = wfTimestamp() + 2 * 60 * 60; + $block->mExpiry = wfTimestamp( TS_MW, $newExpiry ); + $block->update(); + $user2tmp = $this->getTestUser()->getUser(); + $request2 = new FauxRequest(); + $request2->getSession()->setUser( $user2tmp ); + $user2 = User::newFromSession( $request2 ); + $user2->mBlock = $block; + $user2->load(); + $cookies = $request2->response()->getCookies(); + $this->assertEquals( wfTimestamp( TS_MW, $newExpiry ), $block->getExpiry() ); + $this->assertEquals( $newExpiry, $cookies['wm_infinite_blockBlockID']['expire'] ); + + // Clean up. + $block->delete(); + } + + public function testSoftBlockRanges() { + $setSessionUser = function ( User $user, WebRequest $request ) { + $this->setMwGlobals( 'wgUser', $user ); + RequestContext::getMain()->setUser( $user ); + RequestContext::getMain()->setRequest( $request ); + TestingAccessWrapper::newFromObject( $user )->mRequest = $request; + $request->getSession()->setUser( $user ); + }; + $this->setMwGlobals( 'wgSoftBlockRanges', [ '10.0.0.0/8' ] ); + + // IP isn't in $wgSoftBlockRanges + $wgUser = new User(); + $request = new FauxRequest(); + $request->setIP( '192.168.0.1' ); + $setSessionUser( $wgUser, $request ); + $this->assertNull( $wgUser->getBlock() ); + + // IP is in $wgSoftBlockRanges + $wgUser = new User(); + $request = new FauxRequest(); + $request->setIP( '10.20.30.40' ); + $setSessionUser( $wgUser, $request ); + $block = $wgUser->getBlock(); + $this->assertInstanceOf( Block::class, $block ); + $this->assertSame( 'wgSoftBlockRanges', $block->getSystemBlockType() ); + + // Make sure the block is really soft + $wgUser = $this->getTestUser()->getUser(); + $request = new FauxRequest(); + $request->setIP( '10.20.30.40' ); + $setSessionUser( $wgUser, $request ); + $this->assertFalse( $wgUser->isAnon(), 'sanity check' ); + $this->assertNull( $wgUser->getBlock() ); + } + + /** + * Test that a modified BlockID cookie doesn't actually load the relevant block (T152951). + */ + public function testAutoblockCookieInauthentic() { + // Set up the bits of global configuration that we use. + $this->setMwGlobals( [ + 'wgCookieSetOnAutoblock' => true, + 'wgCookiePrefix' => 'wmsitetitle', + 'wgSecretKey' => MWCryptRand::generateHex( 64, true ), + ] ); + + // Unregister the hooks for proper unit testing + $this->mergeMwGlobalArrayValue( 'wgHooks', [ + 'PerformRetroactiveAutoblock' => [] + ] ); + + // 1. Log in a blocked test user. + $userBlocker = $this->getTestSysop()->getUser(); + $user1tmp = $this->getTestUser()->getUser(); + $request1 = new FauxRequest(); + $request1->getSession()->setUser( $user1tmp ); + $block = new Block( [ 'enableAutoblock' => true ] ); + $block->setBlocker( $this->getTestSysop()->getUser() ); + $block->setTarget( $user1tmp ); + $block->setBlocker( $userBlocker ); + $res = $block->insert(); + $this->assertTrue( (bool)$res['id'], 'Failed to insert block' ); + $user1 = User::newFromSession( $request1 ); + $user1->mBlock = $block; + $user1->load(); + + // 2. Create a new request, set the cookie to an invalid value, and make sure the (anon) + // user not blocked. + $request2 = new FauxRequest(); + $request2->setCookie( 'BlockID', $block->getId() . '!zzzzzzz' ); + $user2 = User::newFromSession( $request2 ); + $user2->load(); + $this->assertTrue( $user2->isAnon() ); + $this->assertFalse( $user2->isLoggedIn() ); + $this->assertFalse( $user2->isBlocked() ); + + // Clean up. + $block->delete(); + } + + /** + * The BlockID cookie is normally verified with a HMAC, but not if wgSecretKey is not set. + * This checks that a non-authenticated cookie still works. + */ + public function testAutoblockCookieNoSecretKey() { + // Set up the bits of global configuration that we use. + $this->setMwGlobals( [ + 'wgCookieSetOnAutoblock' => true, + 'wgCookiePrefix' => 'wmsitetitle', + 'wgSecretKey' => null, + ] ); + + // Unregister the hooks for proper unit testing + $this->mergeMwGlobalArrayValue( 'wgHooks', [ + 'PerformRetroactiveAutoblock' => [] + ] ); + + // 1. Log in a blocked test user. + $userBlocker = $this->getTestSysop()->getUser(); + $user1tmp = $this->getTestUser()->getUser(); + $request1 = new FauxRequest(); + $request1->getSession()->setUser( $user1tmp ); + $block = new Block( [ 'enableAutoblock' => true ] ); + $block->setBlocker( $this->getTestSysop()->getUser() ); + $block->setTarget( $user1tmp ); + $block->setBlocker( $userBlocker ); + $res = $block->insert(); + $this->assertTrue( (bool)$res['id'], 'Failed to insert block' ); + $user1 = User::newFromSession( $request1 ); + $user1->mBlock = $block; + $user1->load(); + $this->assertTrue( $user1->isBlocked() ); + + // 2. Create a new request, set the cookie to just the block ID, and the user should + // still get blocked when they log in again. + $request2 = new FauxRequest(); + $request2->setCookie( 'BlockID', $block->getId() ); + $user2 = User::newFromSession( $request2 ); + $user2->load(); + $this->assertNotEquals( $user1->getId(), $user2->getId() ); + $this->assertNotEquals( $user1->getToken(), $user2->getToken() ); + $this->assertTrue( $user2->isAnon() ); + $this->assertFalse( $user2->isLoggedIn() ); + $this->assertTrue( $user2->isBlocked() ); + $this->assertEquals( true, $user2->getBlock()->isAutoblocking() ); // Non-strict type-check. + + // Clean up. + $block->delete(); + } + + /** + * @covers User::isPingLimitable + */ + public function testIsPingLimitable() { + $request = new FauxRequest(); + $request->setIP( '1.2.3.4' ); + $user = User::newFromSession( $request ); + + $this->setMwGlobals( 'wgRateLimitsExcludedIPs', [] ); + $this->assertTrue( $user->isPingLimitable() ); + + $this->setMwGlobals( 'wgRateLimitsExcludedIPs', [ '1.2.3.4' ] ); + $this->assertFalse( $user->isPingLimitable() ); + + $this->setMwGlobals( 'wgRateLimitsExcludedIPs', [ '1.2.3.0/8' ] ); + $this->assertFalse( $user->isPingLimitable() ); + + $this->setMwGlobals( 'wgRateLimitsExcludedIPs', [] ); + $noRateLimitUser = $this->getMockBuilder( User::class )->disableOriginalConstructor() + ->setMethods( [ 'getIP', 'getRights' ] )->getMock(); + $noRateLimitUser->expects( $this->any() )->method( 'getIP' )->willReturn( '1.2.3.4' ); + $noRateLimitUser->expects( $this->any() )->method( 'getRights' )->willReturn( [ 'noratelimit' ] ); + $this->assertFalse( $noRateLimitUser->isPingLimitable() ); + } + + public function provideExperienceLevel() { + return [ + [ 2, 2, 'newcomer' ], + [ 12, 3, 'newcomer' ], + [ 8, 5, 'newcomer' ], + [ 15, 10, 'learner' ], + [ 450, 20, 'learner' ], + [ 460, 33, 'learner' ], + [ 525, 28, 'learner' ], + [ 538, 33, 'experienced' ], + ]; + } + + /** + * @covers User::getExperienceLevel + * @dataProvider provideExperienceLevel + */ + public function testExperienceLevel( $editCount, $memberSince, $expLevel ) { + $this->setMwGlobals( [ + 'wgLearnerEdits' => 10, + 'wgLearnerMemberSince' => 4, + 'wgExperiencedUserEdits' => 500, + 'wgExperiencedUserMemberSince' => 30, + ] ); + + $db = wfGetDB( DB_MASTER ); + $userQuery = User::getQueryInfo(); + $row = $db->selectRow( + $userQuery['tables'], + $userQuery['fields'], + [ 'user_id' => $this->getTestUser()->getUser()->getId() ], + __METHOD__, + [], + $userQuery['joins'] + ); + $row->user_editcount = $editCount; + $row->user_registration = $db->timestamp( time() - $memberSince * 86400 ); + $user = User::newFromRow( $row ); + + $this->assertEquals( $expLevel, $user->getExperienceLevel() ); + } + + /** + * @covers User::getExperienceLevel + */ + public function testExperienceLevelAnon() { + $user = User::newFromName( '10.11.12.13', false ); + + $this->assertFalse( $user->getExperienceLevel() ); + } + + public static function provideIsLocallBlockedProxy() { + return [ + [ '1.2.3.4', '1.2.3.4' ], + [ '1.2.3.4', '1.2.3.0/16' ], + ]; + } + + /** + * @dataProvider provideIsLocallBlockedProxy + * @covers User::isLocallyBlockedProxy + */ + public function testIsLocallyBlockedProxy( $ip, $blockListEntry ) { + $this->setMwGlobals( + 'wgProxyList', [] + ); + $this->assertFalse( User::isLocallyBlockedProxy( $ip ) ); + + $this->setMwGlobals( + 'wgProxyList', + [ + $blockListEntry + ] + ); + $this->assertTrue( User::isLocallyBlockedProxy( $ip ) ); + + $this->setMwGlobals( + 'wgProxyList', + [ + 'test' => $blockListEntry + ] + ); + $this->assertTrue( User::isLocallyBlockedProxy( $ip ) ); + + $this->hideDeprecated( + 'IP addresses in the keys of $wgProxyList (found the following IP ' . + 'addresses in keys: ' . $blockListEntry . ', please move them to values)' + ); + $this->setMwGlobals( + 'wgProxyList', + [ + $blockListEntry => 'test' + ] + ); + $this->assertTrue( User::isLocallyBlockedProxy( $ip ) ); + } + + public function testActorId() { + $this->hideDeprecated( 'User::selectFields' ); + + // Newly-created user has an actor ID + $user = User::createNew( 'UserTestActorId1' ); + $id = $user->getId(); + $this->assertTrue( $user->getActorId() > 0, 'User::createNew sets an actor ID' ); + + $user = User::newFromName( 'UserTestActorId2' ); + $user->addToDatabase(); + $this->assertTrue( $user->getActorId() > 0, 'User::addToDatabase sets an actor ID' ); + + $user = User::newFromName( 'UserTestActorId1' ); + $this->assertTrue( $user->getActorId() > 0, 'Actor ID can be retrieved for user loaded by name' ); + + $user = User::newFromId( $id ); + $this->assertTrue( $user->getActorId() > 0, 'Actor ID can be retrieved for user loaded by ID' ); + + $user2 = User::newFromActorId( $user->getActorId() ); + $this->assertEquals( $user->getId(), $user2->getId(), + 'User::newFromActorId works for an existing user' ); + + $row = $this->db->selectRow( 'user', User::selectFields(), [ 'user_id' => $id ], __METHOD__ ); + $user = User::newFromRow( $row ); + $this->assertTrue( $user->getActorId() > 0, + 'Actor ID can be retrieved for user loaded with User::selectFields()' ); + + $this->db->delete( 'actor', [ 'actor_user' => $id ], __METHOD__ ); + User::purge( wfWikiId(), $id ); + // Because WANObjectCache->delete() stupidly doesn't delete from the process cache. + ObjectCache::getMainWANInstance()->clearProcessCache(); + + $user = User::newFromId( $id ); + $this->assertFalse( $user->getActorId() > 0, 'No Actor ID by default if none in database' ); + $this->assertTrue( $user->getActorId( $this->db ) > 0, 'Actor ID can be created if none in db' ); + + $user->setName( 'UserTestActorId4-renamed' ); + $user->saveSettings(); + $this->assertEquals( + $user->getName(), + $this->db->selectField( + 'actor', 'actor_name', [ 'actor_id' => $user->getActorId() ], __METHOD__ + ), + 'User::saveSettings updates actor table for name change' + ); + + // For sanity + $ip = '192.168.12.34'; + $this->db->delete( 'actor', [ 'actor_name' => $ip ], __METHOD__ ); + + $user = User::newFromName( $ip, false ); + $this->assertFalse( $user->getActorId() > 0, 'Anonymous user has no actor ID by default' ); + $this->assertTrue( $user->getActorId( $this->db ) > 0, + 'Actor ID can be created for an anonymous user' ); + + $user = User::newFromName( $ip, false ); + $this->assertTrue( $user->getActorId() > 0, 'Actor ID can be loaded for an anonymous user' ); + $user2 = User::newFromActorId( $user->getActorId() ); + $this->assertEquals( $user->getName(), $user2->getName(), + 'User::newFromActorId works for an anonymous user' ); + } + + public function testNewFromAnyId() { + // Registered user + $user = $this->getTestUser()->getUser(); + for ( $i = 1; $i <= 7; $i++ ) { + $test = User::newFromAnyId( + ( $i & 1 ) ? $user->getId() : null, + ( $i & 2 ) ? $user->getName() : null, + ( $i & 4 ) ? $user->getActorId() : null + ); + $this->assertSame( $user->getId(), $test->getId() ); + $this->assertSame( $user->getName(), $test->getName() ); + $this->assertSame( $user->getActorId(), $test->getActorId() ); + } + + // Anon user. Can't load by only user ID when that's 0. + $user = User::newFromName( '192.168.12.34', false ); + $user->getActorId( $this->db ); // Make sure an actor ID exists + + $test = User::newFromAnyId( null, '192.168.12.34', null ); + $this->assertSame( $user->getId(), $test->getId() ); + $this->assertSame( $user->getName(), $test->getName() ); + $this->assertSame( $user->getActorId(), $test->getActorId() ); + $test = User::newFromAnyId( null, null, $user->getActorId() ); + $this->assertSame( $user->getId(), $test->getId() ); + $this->assertSame( $user->getName(), $test->getName() ); + $this->assertSame( $user->getActorId(), $test->getActorId() ); + + // Bogus data should still "work" as long as nothing triggers a ->load(), + // and accessing the specified data shouldn't do that. + $test = User::newFromAnyId( 123456, 'Bogus', 654321 ); + $this->assertSame( 123456, $test->getId() ); + $this->assertSame( 'Bogus', $test->getName() ); + $this->assertSame( 654321, $test->getActorId() ); + + // Exceptional cases + try { + User::newFromAnyId( null, null, null ); + $this->fail( 'Expected exception not thrown' ); + } catch ( InvalidArgumentException $ex ) { + } + try { + User::newFromAnyId( 0, null, 0 ); + $this->fail( 'Expected exception not thrown' ); + } catch ( InvalidArgumentException $ex ) { + } + } + + /** + * @covers User::getBlockedStatus + * @covers User::getBlock + * @covers User::blockedBy + * @covers User::blockedFor + * @covers User::isHidden + * @covers User::isBlockedFrom + */ + public function testBlockInstanceCache() { + // First, check the user isn't blocked + $user = $this->getMutableTestUser()->getUser(); + $ut = Title::makeTitle( NS_USER_TALK, $user->getName() ); + $this->assertNull( $user->getBlock( false ), 'sanity check' ); + $this->assertSame( '', $user->blockedBy(), 'sanity check' ); + $this->assertSame( '', $user->blockedFor(), 'sanity check' ); + $this->assertFalse( (bool)$user->isHidden(), 'sanity check' ); + $this->assertFalse( $user->isBlockedFrom( $ut ), 'sanity check' ); + + // Block the user + $blocker = $this->getTestSysop()->getUser(); + $block = new Block( [ + 'hideName' => true, + 'allowUsertalk' => false, + 'reason' => 'Because', + ] ); + $block->setTarget( $user ); + $block->setBlocker( $blocker ); + $res = $block->insert(); + $this->assertTrue( (bool)$res['id'], 'sanity check: Failed to insert block' ); + + // Clear cache and confirm it loaded the block properly + $user->clearInstanceCache(); + $this->assertInstanceOf( Block::class, $user->getBlock( false ) ); + $this->assertSame( $blocker->getName(), $user->blockedBy() ); + $this->assertSame( 'Because', $user->blockedFor() ); + $this->assertTrue( (bool)$user->isHidden() ); + $this->assertTrue( $user->isBlockedFrom( $ut ) ); + + // Unblock + $block->delete(); + + // Clear cache and confirm it loaded the not-blocked properly + $user->clearInstanceCache(); + $this->assertNull( $user->getBlock( false ) ); + $this->assertSame( '', $user->blockedBy() ); + $this->assertSame( '', $user->blockedFor() ); + $this->assertFalse( (bool)$user->isHidden() ); + $this->assertFalse( $user->isBlockedFrom( $ut ) ); + } + +} |