1 files changed, 125 insertions, 0 deletions
diff --git a/www/wiki/tests/phpunit/includes/GlobalFunctions/wfUrlencodeTest.php b/www/wiki/tests/phpunit/includes/GlobalFunctions/wfUrlencodeTest.php
new file mode 100644
index 00000000..09c1040b
--- /dev/null
+++ b/www/wiki/tests/phpunit/includes/GlobalFunctions/wfUrlencodeTest.php
@@ -0,0 +1,125 @@
+<?php
+
+/**
+ * The function only need a string parameter and might react to IIS7.0
+ *
+ * @group GlobalFunctions
+ * @covers ::wfUrlencode
+ */
+class WfUrlencodeTest extends MediaWikiTestCase {
+	# ### TESTS ##############################################################
+
+	/**
+	 * @dataProvider provideURLS
+	 */
+	public function testEncodingUrlWith( $input, $expected ) {
+		$this->verifyEncodingFor( 'Apache', $input, $expected );
+	}
+
+	/**
+	 * @dataProvider provideURLS
+	 */
+	public function testEncodingUrlWithMicrosoftIis7( $input, $expected ) {
+		$this->verifyEncodingFor( 'Microsoft-IIS/7', $input, $expected );
+	}
+
+	# ### HELPERS #############################################################
+
+	/**
+	 * Internal helper that actually run the test.
+	 * Called by the public methods testEncodingUrlWith...()
+	 */
+	private function verifyEncodingFor( $server, $input, $expectations ) {
+		$expected = $this->extractExpect( $server, $expectations );
+
+		// save up global
+		$old = isset( $_SERVER['SERVER_SOFTWARE'] )
+			? $_SERVER['SERVER_SOFTWARE']
+			: null;
+		$_SERVER['SERVER_SOFTWARE'] = $server;
+		wfUrlencode( null );
+
+		// do the requested test
+		$this->assertEquals(
+			$expected,
+			wfUrlencode( $input ),
+			"Encoding '$input' for server '$server' should be '$expected'"
+		);
+
+		// restore global
+		if ( $old === null ) {
+			unset( $_SERVER['SERVER_SOFTWARE'] );
+		} else {
+			$_SERVER['SERVER_SOFTWARE'] = $old;
+		}
+		wfUrlencode( null );
+	}
+
+	/**
+	 * Interprets the provider array. Return expected value depending
+	 * the HTTP server name.
+	 */
+	private function extractExpect( $server, $expectations ) {
+		if ( is_string( $expectations ) ) {
+			return $expectations;
+		} elseif ( is_array( $expectations ) ) {
+			if ( !array_key_exists( $server, $expectations ) ) {
+				throw new MWException( __METHOD__ . " expectation does not have any "
+					. "value for server name $server. Check the provider array.\n" );
+			} else {
+				return $expectations[$server];
+			}
+		} else {
+			throw new MWException( __METHOD__ . " given invalid expectation for "
+				. "'$server'. Should be a string or an array( <http server name> => <string> ).\n" );
+		}
+	}
+
+	# ### PROVIDERS ###########################################################
+
+	/**
+	 * Format is either:
+	 *   [ 'input', 'expected' ];
+	 * Or:
+	 *   [ 'input',
+	 *       [ 'Apache', 'expected' ],
+	 *       [ 'Microsoft-IIS/7', 'expected' ],
+	 *   ],
+	 * If you want to add other HTTP server name, you will have to add a new
+	 * testing method much like the testEncodingUrlWith() method above.
+	 */
+	public static function provideURLS() {
+		return [
+			# ## RFC 1738 chars
+			// + is not safe
+			[ '+', '%2B' ],
+			// & and = not safe in queries
+			[ '&', '%26' ],
+			[ '=', '%3D' ],
+
+			[ ':', [
+				'Apache' => ':',
+				'Microsoft-IIS/7' => '%3A',
+			] ],
+
+			// remaining chars do not need encoding
+			[
+				';@$-_.!*',
+				';@$-_.!*',
+			],
+
+			# ## Other tests
+			// slash remain unchanged. %2F seems to break things
+			[ '/', '/' ],
+			// T105265
+			[ '~', '~' ],
+
+			// Other 'funnies' chars
+			[ '[]', '%5B%5D' ],
+			[ '<>', '%3C%3E' ],
+
+			// Apostrophe is encoded
+			[ '\'', '%27' ],
+		];
+	}
+}